Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROWORCOLST problem with decision from #1722 #4425

Closed
DerGuteWolf opened this issue Jan 19, 2021 · 5 comments
Closed

ROWORCOLST problem with decision from #1722 #4425

DerGuteWolf opened this issue Jan 19, 2021 · 5 comments
Assignees

Comments

@DerGuteWolf
Copy link
Collaborator

DerGuteWolf commented Jan 19, 2021

With #1722 #1791 a ROWORCOLST setting of 'C' is always serialized as blank.

We frequently use abapGit with tables set to column store. However this is setting is not carried over by abapGit (cf above).

Some of these tables have FullTextIndizes (FTI). When now the table is deserialized the column store setting in ROWORCOLST of 'C' is removed which gives afterwards an error for the table because FTI Indizes are only valid if this is set explicitly to 'C' and are not valid if this is set to blank. This error prevents activation of the table and dependent stuff. After every(!) pull we have for every(!) such table manually(!) access the technical settings of the table and set this to C and then we can activate the technical settings (which thankfully activates all dependent stuff).

So could we amend the change from #1722 #1791 with a mechanism in deserialize that if the field ROWORCOLST is there and the value is blank, it is set to C?

If this would be ok for you, I can do this as a test in our system and provide you with a pull request.

@mbtools
Copy link
Member

mbtools commented Jan 19, 2021

It's the typical case of a "new feature in a newer release". imho, the field should be serialized with the proper value (ie. R or C) if it exists in a given release (no mapping of field content). If imported on a lower release, you will get a diff like with any field that doesn't exist.

@larshp
Copy link
Member

larshp commented Jan 20, 2021

if its blank, and ROWORCOLST exists in the system, default the value to 'C'

DerGuteWolf added a commit to DerGuteWolf/abapGit that referenced this issue Jan 20, 2021
@DerGuteWolf
Copy link
Collaborator Author

DerGuteWolf commented Jan 20, 2021

I created pull request #4430 This worked in our system, the tables with FTI were activated on a pull, no errors anymore.

larshp pushed a commit that referenced this issue Jan 21, 2021
* Fix for #4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
JustACasual added a commit to JustACasual/abapGit that referenced this issue Jan 21, 2021
* Fix for abapGit#4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@larshp
Copy link
Member

larshp commented Jan 23, 2021

@DerGuteWolf can this issue be closed?

@larshp
Copy link
Member

larshp commented Jan 25, 2021

closing

@larshp larshp closed this as completed Jan 25, 2021
larshp added a commit that referenced this issue Jan 31, 2021
* Issue 2424

#2424

* Issue 2424

#2424

* Update src/objects/zcl_abapgit_object_fugr.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Fixing LINT issues

* Fixing LINT issues

* TABL, default ROWORCOLST on deserialize (#4430) (#4)

* Fix for #4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Centralize LXE functionality

* Fix FUGR LXE

* delete issue reference comments

* Delete issue reference comments

* Remove Aliases for LXE types

* Review Changes

* Copy from #4452

Integrate changes from #4452 into #4415

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: Sebastian Koitka <sebastian.koitka@dematic.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants