SAP GUI for Java: New commit page is non-functional (mac)

[sbcgua]

:(

It keeps asking name email and comment.

@mbtools

[mbtools]

odd. the other forms like "settings" work? i will test tomorrow on another machine that has JavaGui installed

It might be related to #2448 due to the @

[mbtools]

Hmmm. I tested with 7.70 rev 3 (latest) and the commit form works without problems 🤷

[sbcgua]

The version I used was 7.4 ... will check how it goes with a newer one

[christianguenter2]

@mbtools did I get you right, you've been able to commit with SAPGUI for Java without problems?
It doesn't work for a colleague of mine with this error but he's on MacOS.

It once was fixed with #790 actually.

[mbtools]

Yes, indeed. Same version.

[mbtools]

Retested with Java GUI. 7.80 rev 1

There is some bug here. After "Stage" the add/remove column does not show the "add" link.

JavaGUI:

[
WinGUI for comparison:

]

After clicking "add" in the column header, it seems like it's working

but clicking "Commit" leads to the error described above

StageHelper is using window.sessionStorage which does not seem to work on JavaGUI:

My JS skills aren't good enough to fix this 😉

Ref #5901

[AndreaBorgia-Abo]

Same Java GUI, this time on Linux.
(aG is developer version 1.121.0)

Silly me, forgetting that once a bug has seen me, I'm toast :D
After the test above, I fired up Win11 on my laptop to use GUI 8.00 and, you guessed it, no luck there either :(

Uninstalled 8.00, reinstalled 7.70PL10 and the commit went ahead just fine.

[mbtools]

SAP GUI for Win 8.0 issue is due to Chrome-based control (#4841)

Easy workaround: See https://docs.abapgit.org/guide-sapgui.html

[AndreaBorgia-Abo]

Reinstalled 8.00, switched control, checking soon... no.1 works fine, thanks.

[mbtools]

Trace of SAP GUI for Java 7.80 rev 2 reveals the following error

############################# ERROR #############################
09.05. 21:53:16.653 ERROR: SAPEVENT: SapEvent occured without being registered to browser instance: sapevent:stage_commit
############################# ERROR #############################
############################# ERROR #############################
09.05. 22:13:09.774 ERROR: SAPEVENT: SapEvent occured without being registered to browser instance: sapevent:go_patch
############################# ERROR #############################

These errors are all related to events triggered by JavaScript:

abapGit/src/ui/zabapgit_js_common.w3mi.data.js

Lines 110 to 148 in 5d44df5

	function submitSapeventForm(params, action, method, form) {
	function getSapeventPrefix() {
	if (document.querySelector('a[href*="file:///SAPEVENT:"]')) {
	return "file:///"; //Prefix for chromium based browser control
	} else {
	return "";
	}
	}
	var stub_form_id = "form_" + action;
	form = form
	|| document.getElementById(stub_form_id)
	|| document.createElement("form");
	form.setAttribute("method", method || "post");
	if (/sapevent/i.test(action)) {
	form.setAttribute("action", action);
	} else {
	form.setAttribute("action", getSapeventPrefix() + "SAPEVENT:" + action);
	}
	for (var key in params) {
	var hiddenField = document.createElement("input");
	hiddenField.setAttribute("type", "hidden");
	hiddenField.setAttribute("name", key);
	hiddenField.setAttribute("value", params[key]);
	form.appendChild(hiddenField);
	}
	var formExistsInDOM = form.id && Boolean(document.querySelector("#" + form.id));
	if (form.id !== stub_form_id && !formExistsInDOM) {
	document.body.appendChild(form);
	}
	form.submit();
	}

This feature is used by the following actions (stage and patch pages):

stage_commit
stage_filter
patch_stage
yank_to_clipboard
go_back
refresh_local
refresh_all

The million $ question: How do you prevent the error?

[christianguenter2]

7.80 rev 4 'Add Filtered and Commit' doesn't work. Nothing happens.

############################# ERROR #############################
27.10. 08:42:53.926 ERROR: SAPEVENT: SapEvent occured without being registered to browser instance: sapevent:stage_commit
############################# ERROR #############################

same as above

[christianguenter2]

I try to draw SAPs attention to this issue.
https://blogs.sap.com/2022/05/25/sap-gui-for-java-7.80/comment-page-1/#comment-693974

[christianguenter2]

Colleague of mine raised an issue at SAP. Let's see where that goes.

[christianguenter2]

Colleague of mine raised an issue at SAP. Let's see where that goes.

Good news!

Case at SAP was successful. With unofficial Java Gui release 7.8 rev5.2 the issues are fixed and according to my colleague abapGit with Java Gui is fully functional on his Mac with ARM processor. I assume it will be released as 7.8 PL 6 in the near future. Kudos to SAP support who did a great job 🥇

[mbtools]

Excellent! Once you bust through primary support and exchange directly with a developer, you have a good chance of getting a fix 👍 Thanks for the effort!

[mbtools]

7.8 PL 6 is available. Anyone available to test this?

https://me.sap.com/softwarecenterviewer/73555000100200015948/MAINT

[christianguenter2]

Installed it on windows and did some tests. Looks good at first sight. Asked my colleague who uses it on mac to do further testing.

[AndreaBorgia-Abo]

FWIW tested on Linux against A4H, commit worked

[mbtools]

Here are the actions to test (because they use JS to trigger event):

On staging:

• commit (looks like it works 👍 )
• filtering
• patch (and then stage)

On diff:

• refresh local
• refresh all

Vimium-links, yank mode:

• yank_to_clipboard

[christianguenter2]

Further test results on windows:

✔️ working

• commit
• filtering
• patch
• refresh local
• refresh all

❌ not working

• hotkeys
• vimium features
• command palettes

[larshp]

but overall, its pretty good news?

[christianguenter2]

but overall, its pretty good news?

Yes absolutely. All major features working.

[christianguenter2]

Feedback from colleague testing on mac "works wonderfully" 🎆