-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP GUI for Windows: Issues with chromium-based browser control (WebView/Edge) #4841
Comments
I just test the PL03 and it seems that all the problems (or at least almost) are fixed. @christianguenter2 can you test it with the last PL03? |
Thanks for the info. I just did a quick test and some issues are fixed (marked above). Few still exist. |
The issue reported to SAP was closed by inactivity, I was waiting for this patch to test and report feedback. |
This week a hotfix for PL3 was released, maybe some issues was fixed |
Thanks for the hint. Just tested PL3 Hotfix 1. Issues still exist. |
I tested the staging problem with PL4 and it still exists, though for me it happens on any filter action, not just the "Changed by (me)". Haven't tested the other open topics. |
Small update: The staging issue and filtering issue still exists with SAP GUI 7.70 PL5. |
It looks to me like the remaining issues are related to the use of "Custom URI Scheme support: Webview2 currently does not have Custom URI Scheme support (URLs starts with SAPHTML, SAPHTMLP, SAPEVENT, SAPR3 etc). Microsoft is working on this feature. As per recent communication from Microsoft the APIs will be available from Edge browser version 103(Microsoft initially told 102 version but now it is postponed by them). For Edge browser version release dates please refer https://docs.microsoft.com/en-us/deployedge/microsoft-edge-release-schedule. After this SAP requires at least two to three months time to consume these APIs and release to customers." Revisiting the issue end of August 2022 seems feasible. |
Further delays: Looks like Sept 2022 + 3 months. |
I've just updated Edge to: Version 109.0.1518.55 (Official build) (64-bit) and I can confirm that this issue still does exist. Will watch SAP Note 3228419 now. |
Add BrowserControlFallback.xml which can be used to configure the solution described in SAP Note 2957665 - SAP GUI HTML Control: Browser Control Fallback Configuration. Ref abapGit/abapGit#4841
I think I see the issue: The actions are in upper case but AG expects them lower case. @WegnerDan can you test the following fix, please? https://github.com/abapGit/abapGit/blob/main/src/ui/core/zcl_abapgit_gui_event.clas.abap#L47 zif_abapgit_gui_event~mv_action = to_lower( iv_action ). |
Yep, this works! |
Edge Webview browser control returns upper case action but abapGit requires lower case. Ref #4841
See #6336. Does "Patch" and "Staging" work with this, too (see above)? |
Yep, "Patch" and "Staging" also works |
Excellent. Thanks! |
What is the solution for this issue? i found only note 331099 here. his note is not relevant on my system. Still have SAPGUI 770 patchlevel 5 |
#6339 is still open and tracking the overall status. We will need to adjust AG to handle the uppercase SAPEVENT and wait for the next SAP GUI patch that fixes encoding of URL parameters including slashes. |
Collection of issues as discussed in the slack channel and PR #4840
These errors only occur with SAPGUI 7.70 for windows PL2 and chromium based browser control. None of the occur with IE control or with previous patch level.
"Unknown action: SELECT" -> Unknown action error using Edge with GUI 7.70 PL02 #4840
Back navigation doesn't work -> Unknown action error using Edge with GUI 7.70 PL02 #4840 (comment)
Patch doesn't work - add file and click 'Patch'
![image](https://user-images.githubusercontent.com/17437789/121778138-ece61780-cb95-11eb-9af3-a2097200ea6c.png)
Diff doesn't work -> Shortdump
![image](https://user-images.githubusercontent.com/17437789/121778192-2c146880-cb96-11eb-8b79-69a98ef6d585.png)
![image](https://user-images.githubusercontent.com/17437789/121778195-2fa7ef80-cb96-11eb-9a1c-6624d8358431.png)
![image](https://user-images.githubusercontent.com/17437789/121778196-320a4980-cb96-11eb-8f8f-1c68c8e8a413.png)
![image](https://user-images.githubusercontent.com/17437789/121778200-346ca380-cb96-11eb-95af-c2a6527dbcb4.png)
Filename is UPPERCASE
Stage page: 'Change by (me)' doesn't work
![image](https://user-images.githubusercontent.com/17437789/121778392-ff148580-cb96-11eb-88d4-dd884c018fe3.png)
![image](https://user-images.githubusercontent.com/17437789/121778389-fc199500-cb96-11eb-821f-ffba06952d2f.png)
Bad performance. Every navigation step/action takes ~2 seconds
The text was updated successfully, but these errors were encountered: