Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP GUI for Windows: Issues with chromium-based browser control (WebView/Edge) #4841

Closed
6 tasks done
christianguenter2 opened this issue Jun 12, 2021 · 25 comments · Fixed by #6336
Closed
6 tasks done
Labels
bug Something isn't working sapfix Waiting for or need to apply SAP note or patch

Comments

@christianguenter2
Copy link
Member

christianguenter2 commented Jun 12, 2021

Collection of issues as discussed in the slack channel and PR #4840
These errors only occur with SAPGUI 7.70 for windows PL2 and chromium based browser control. None of the occur with IE control or with previous patch level.

@jrodriguez-rc
Copy link
Contributor

I just test the PL03 and it seems that all the problems (or at least almost) are fixed.

@christianguenter2 can you test it with the last PL03?

@christianguenter2
Copy link
Member Author

christianguenter2 commented Aug 6, 2021

Thanks for the info. I just did a quick test and some issues are fixed (marked above). Few still exist.
@jrodriguez-rc Is your OSS call still open? If yes can forward that to SAP? Many thanks for your effort.

@jrodriguez-rc
Copy link
Contributor

The issue reported to SAP was closed by inactivity, I was waiting for this patch to test and report feedback.

@jrodriguez-rc
Copy link
Contributor

This week a hotfix for PL3 was released, maybe some issues was fixed

@christianguenter2
Copy link
Member Author

christianguenter2 commented Aug 27, 2021

Thanks for the hint. Just tested PL3 Hotfix 1. Issues still exist.

@mkaesemann
Copy link
Contributor

I tested the staging problem with PL4 and it still exists, though for me it happens on any filter action, not just the "Changed by (me)". Haven't tested the other open topics.

@mbtools mbtools changed the title SAPGUI 7.70 PL2 - Several issuse with chromium based browser control SAPGUI 7.70 - Issues with chromium-based browser control (WebView/Edge) Oct 29, 2021
@mkaesemann
Copy link
Contributor

mkaesemann commented Jan 28, 2022

Small update: The staging issue and filtering issue still exists with SAP GUI 7.70 PL5.

@mbtools
Copy link
Member

mbtools commented Jun 21, 2022

It looks to me like the remaining issues are related to the use of SAPEVENT: within the abapGit JavaScript (to submit a form). The Edge control does not support this (yet). This is documented in SAP Note 2901278:

"Custom URI Scheme support: Webview2 currently does not have Custom URI Scheme support (URLs starts with SAPHTML, SAPHTMLP, SAPEVENT, SAPR3 etc). Microsoft is working on this feature. As per recent communication from Microsoft the APIs will be available from Edge browser version 103(Microsoft initially told 102 version but now it is postponed by them). For Edge browser version release dates please refer https://docs.microsoft.com/en-us/deployedge/microsoft-edge-release-schedule. After this SAP requires at least two to three months time to consume these APIs and release to customers."

Revisiting the issue end of August 2022 seems feasible.

@mbtools
Copy link
Member

mbtools commented Jul 20, 2022

Further delays: Looks like Sept 2022 + 3 months.

@christianguenter2
Copy link
Member Author

SAP Note 2901278 was updated regarding SAPEVENT and new note 3228419 was created.

grafik

Though not yet released.
grafik

@mbtools
Copy link
Member

mbtools commented Oct 26, 2022

More delays:

image

@mbtools mbtools added the sapfix Waiting for or need to apply SAP note or patch label Nov 23, 2022
@gregorwolf
Copy link
Contributor

I've just updated Edge to:

Version 109.0.1518.55 (Official build) (64-bit)

and I can confirm that this issue still does exist. Will watch SAP Note 3228419 now.

mbtools added a commit to abapGit/docs.abapgit.org that referenced this issue Jan 17, 2023
Add BrowserControlFallback.xml which can be used to configure the solution described in SAP Note 2957665 - SAP GUI HTML Control: Browser Control Fallback Configuration.

Ref abapGit/abapGit#4841
@mbtools mbtools changed the title SAPGUI 7.70 - Issues with chromium-based browser control (WebView/Edge) SAP GUI for Windows: Issues with chromium-based browser control (WebView/Edge) Feb 8, 2023
@christianguenter2
Copy link
Member Author

Good news I guess
3331099 - SAP GUI for Windows Edge HTML control: Custom URI scheme support is now available

@gregorwolf
Copy link
Contributor

I have a working diff after the upgrade:

Screenshot 2023-06-20 at 18 27 21

@christianguenter2
Copy link
Member Author

christianguenter2 commented Jun 20, 2023

Hm, note says this supposed to be fixed with PL3?
grafik

Can't remember having problems with sole diff.

@christianguenter2
Copy link
Member Author

Note was updated
grafik

@WegnerDan
Copy link
Contributor

WegnerDan commented Jul 7, 2023

SAP GUI 800 PL03 seems to break actions in abapgit:

eclipse_Gm3yijr04u.mp4

Probably related to notes 3337501, 3331099, 3335007

firefox_2Zy8IXBWM7

@mbtools
Copy link
Member

mbtools commented Jul 7, 2023

I think I see the issue: The actions are in upper case but AG expects them lower case. @WegnerDan can you test the following fix, please?

https://github.com/abapGit/abapGit/blob/main/src/ui/core/zcl_abapgit_gui_event.clas.abap#L47

    zif_abapgit_gui_event~mv_action       = to_lower( iv_action ).

@WegnerDan
Copy link
Contributor

Yep, this works!

mbtools added a commit that referenced this issue Jul 7, 2023
Edge Webview browser control returns upper case action but abapGit requires lower case.

Ref #4841
@mbtools
Copy link
Member

mbtools commented Jul 7, 2023

See #6336. Does "Patch" and "Staging" work with this, too (see above)?

@WegnerDan
Copy link
Contributor

Yep, "Patch" and "Staging" also works

@mbtools
Copy link
Member

mbtools commented Jul 7, 2023

Excellent. Thanks!

@ubabap
Copy link

ubabap commented Aug 2, 2023

What is the solution for this issue? i found only note 331099 here. his note is not relevant on my system. Still have SAPGUI 770 patchlevel 5
is it fixed in #6336 ? and also gui patch needed?
Using the last ABAPgit Standalone and SAPGUI 770 patchlevel 5 i still have this issue

@mbtools
Copy link
Member

mbtools commented Aug 2, 2023

#6339 is still open and tracking the overall status. We will need to adjust AG to handle the uppercase SAPEVENT and wait for the next SAP GUI patch that fixes encoding of URL parameters including slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sapfix Waiting for or need to apply SAP note or patch
Development

Successfully merging a pull request may close this issue.

7 participants