Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With 'show changes only' enabled, also filter changed files, not just objects #2740

Merged
merged 3 commits into from
Jun 16, 2019
Merged

With 'show changes only' enabled, also filter changed files, not just objects #2740

merged 3 commits into from
Jun 16, 2019

Conversation

FreHu
Copy link
Collaborator

@FreHu FreHu commented Jun 13, 2019

Solves #2739.

Comparison:
SapGuiServer_xaoSE4Pge3
-->
SapGuiServer_N7hJpJV1ny

Effects best seen on FUGR includes:
SapGuiServer_UaT26UdHDA
-->
SapGuiServer_KCf4jeCnSm

@FreHu FreHu requested a review from sbcgua June 13, 2019 17:43
sbcgua
sbcgua approved these changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@sbcgua sbcgua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look OK for me, good fix :)

@FreHu
Copy link
Collaborator Author

FreHu commented Jun 14, 2019

I just remembered I already suggested this a year ago (in a slightly more convoluted way). Also resolves #1429.

@larshp larshp merged commit abc43d4 into master Jun 16, 2019
@larshp larshp deleted the filter-changes branch June 16, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianlupa fabianlupa fabianlupa left review comments

@sbcgua sbcgua sbcgua approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FreHu @fabianlupa @sbcgua @larshp