Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib/deflate decompression, bugfix #5723

Merged
merged 1 commit into from Aug 18, 2022
Merged

zlib/deflate decompression, bugfix #5723

merged 1 commit into from Aug 18, 2022

Conversation

larshp
Copy link
Member

@larshp larshp commented Aug 17, 2022

ref #5722

takeaways from section 3.2.3, https://www.ietf.org/rfc/rfc1951.txt

uncompressed block might not be the last block

Note that the header bits do not necessarily begin on a byte boundary, since a block does not necessarily occupy an integral number of bytes. Ie. not necessarily 5 bits in the uncompressed case

be patient when opening https://github.com/SAP-samples/logistics-business-network-gtt-standardapps-samples, the abap implementation of zlib is slow, but it loads. Storing PDF files in git is a mess, they are compressed, ie. zlib/deflate does not try to compress it again when transferred over git protocol.

image

@larshp larshp marked this pull request as ready for review August 17, 2022 12:03
@larshp larshp changed the title zlib, bugfix zlib/deflate decompression, bugfix Aug 17, 2022
@larshp
Copy link
Member Author

larshp commented Aug 18, 2022

tested ok, see comment #5722 (comment)

merging

@larshp larshp merged commit 7ac80ce into main Aug 18, 2022
@larshp larshp deleted the hvam/zlib1708 branch August 18, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant