TABL,VIEW: Simplify deserialize #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the years, various workarounds have been implemented to handle dependencies used in tables and views like foreign keys, references to classes or interfaces, or search helps. This led to a two-phase deserialize (`DDIC` and `LATE`). Nevertheless, some test scenarios were still failing (for example, [function group with maintenance views](https://github.com/abapGit-tests/FUGR_maint_view_var)). I created a new test repo covering all these "DDIC dependency scenarios". It also covers dependencies between ABAP and DDIC. See [repo](https://github.com/abapGit-tests/TABL_ddic_integration) and its readme. After #3545, OO references are not a problem anymore and don't require two phases. It turns out that we don't need any of the work arounds and a single DDIC phase is sufficient to deserialize tables and views. The test repo can be deserialized and uninstalled without problems. I will run a complete CI test but am confident that all will work well.
mbtools
added
serialization
|
Another CI run (will publish on Monday). This works well. No issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years, various workarounds have been implemented to handle dependencies used in tables and views like foreign keys, references to classes or interfaces, or search helps. This led to a two-phase deserialize (
DDICandLATE). Nevertheless, some test scenarios were still failing (for example, function group with maintenance views).I created a new test repo covering all these "DDIC dependency scenarios". It also covers dependencies between ABAP and DDIC. See repo and its readme.
After #3545, OO references are not a problem anymore and don't require two phases. It turns out that we don't need any of the work arounds and a single DDIC phase is sufficient to deserialize tables and views.
The test repo can be deserialized and uninstalled without problems. I will run a complete CI test but am confident that all will work well.
Closes #5451 (too)