DOMA: Fix domains with custom conversion exit #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializing a domain that is using a custom conversion exit (custom `CONVERSION_EXIT_<name>_IN|OUTPUT` functions) is failing on the initial pull since the functions do not exits.
Fix is using two-phase approach:
1. DDIC phase:
If function does not exit, remove the exit function
2. LATE phase
If function was removed, change it to the correct exit function
New test repo: https://github.com/abapGit-tests/DOMA_with_exit
mbtools
added
serialization
mbtools
added a commit
that referenced
this pull request
Jan 16, 2023
Refactor handling of dependencies on exit function (using same methods as `DOMA` #5998). This avoids activating the search help twice if the exit function already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing a domain that is using a custom conversion exit (custom
CONVERSION_EXIT_<name>_IN|OUTPUTfunctions) is failing on the initial pull since the functions do not exits.Fix is using two-phase approach:
If function does not exit, remove the exit function
If function was removed, change it to the correct exit function
New test repo: https://github.com/abapGit-tests/DOMA_with_exit