Introduce ABAP Language Version (ALV) to .abapgit.xml #6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasPloski
changed the title
|
Code is part of the solution and looks good to me. However, I don't think we should add this as is. Every newly created repo will get diffs when used in older abapGit versions (not sure what happens if you try to pull). We should mark the feature to be experimental so we can merge without impacting the community. IF zcl_abapgit_persist_factory=>get_settings( )->read( )->get_experimental_features( ) = abap_true.
...
ENDIF. |
9 tasks
|
I will surround the affected coding parts with the mentioned if statement and update the PR. |
Remove default value for ABAP language version in .abapgit.xml
Adapt constant naming
|
One step back: I have decided to not touch the current logic in .abapgit.xml handling, so that surrounding with experimental feature is not required, since there is no defaulting while object creation. |
|
looks like these changes are included in #6346 |
schneidermic0
approved these changes
Jul 14, 2023
|
This PR can be closed since the PR #6346 contains of those changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #6334