Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do the ABAP Language Version for the AFF objects #6375

Merged
merged 19 commits into from Aug 10, 2023
Merged

Do the ABAP Language Version for the AFF objects #6375

merged 19 commits into from Aug 10, 2023

Conversation

albertmink
Copy link
Member

New behaviour:

  • during serialization, the ABAP Language Version is taken from the repository (not from the object)
  • during deserialization, the ABAP Language Version of the repository is set for all objects

Relates to #6154

@albertmink
Apply suggestions from code review
fff036f 
Apply my suggestion ;)
@albertmink albertmink added the aff Related to ABAP File Format label Jul 27, 2023
@albertmink albertmink marked this pull request as ready for review July 27, 2023 16:44
@jfilak
Copy link

jfilak commented Jul 28, 2023

Boys, I am gonna do a little bit of trolling but those commit messages are little bit below the good software engineering standards, don't you think?

@schneidermic0
Copy link
Collaborator

Sorry, I have requested review too early. :/

Let me fix the abaplint I issues, first.

schneidermic0 and others added 3 commits August 3, 2023 15:25
@schneidermic0
Fix abaplint issues
48e865d
@schneidermic0
Fix indentation
d963e9d
@schneidermic0 @abaplint
Update src/objects/aff/zcl_abapgit_object_common_aff.clas.testclasses…
425eedb 
….abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@schneidermic0 schneidermic0 marked this pull request as draft August 3, 2023 14:14
@schneidermic0 schneidermic0 marked this pull request as ready for review August 3, 2023 14:34
Christopher-Hermann
Christopher-Hermann approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@Christopher-Hermann Christopher-Hermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

schneidermic0
schneidermic0 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks fine as well. I would like to wait for @mbtools feedback before I merge it.

@mbtools
Copy link
Member

mbtools commented Aug 4, 2023

🇨🇦 holiday. Back Wednesday

@schneidermic0
Copy link
Collaborator

🇨🇦 holiday. Back Wednesday

No rush. Enjoy!

mbtools
mbtools approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright 👍

@mbtools mbtools mentioned this pull request Aug 10, 2023
Closed
9 tasks
@larshp
Copy link
Member

larshp commented Aug 10, 2023

lets go, merging

@larshp larshp merged commit 90bcac3 into main Aug 10, 2023
6 checks passed
@larshp larshp deleted the minka/aff-alv branch August 10, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbtools mbtools mbtools approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

@Christopher-Hermann Christopher-Hermann Christopher-Hermann approved these changes

Assignees
No one assigned
Labels
aff Related to ABAP File Format
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@albertmink @jfilak @schneidermic0 @mbtools @larshp @Christopher-Hermann