fix syntax (#12)

* update abaplint config * fix * Update .gitignore
abapGit · Feb 3, 2023 · cc0a623 · cc0a623
1 parent e4c641d
commit cc0a623
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,3 @@
+deps1
+
+deps2
diff --git a/abaplint.json b/abaplint.json
@@ -8,12 +8,12 @@
   "dependencies": [
     {
       "url": "https://github.com/abaplint/deps",
-      "folder": "/deps",
+      "folder": "/deps1",
       "files": "/src/**/*.*"
     },
     {
       "url": "https://github.com/abapGit/abapGit",
-      "folder": "/git",
+      "folder": "/deps2",
       "files": "/src/**/*.*"
     }
   ],
@@ -33,7 +33,6 @@
     "check_comments": false,
     "check_ddic": true,
     "check_include": true,
-    "check_no_handler_pragma": true,
     "check_subrc": false,
     "check_text_elements": true,
     "class_attribute_names": true,
@@ -54,9 +53,8 @@
     "keep_single_parameter_on_one_line": true,
     "keyword_case": true,
     "line_break_multiple_parameters": true,
-    "line_break_style": true,
+    "line_break_style": false,
     "local_class_naming": true,
-    "many_parenthesis": true,
     "method_implemented_twice": true,
     "method_length": false,
     "method_overwrites_builtin": true,
@@ -93,12 +91,8 @@
     "ambiguous_statement": true,
     "avoid_use": {
       "define": true,
-      "endselect": true,
-      "execSQL": true,
-      "kernelCall": true,
-      "communication": true,
+      "testSeams": true,
       "statics": true,
-      "systemCall": true,
       "defaultKey": false,
       "break": true,
       "describeLines": true
@@ -125,7 +119,6 @@
     "inline_data_old_versions": true,
     "line_length": true,
     "line_only_punc": true,
-    "local_testclass_location": true,
     "local_variable_names": true,
     "main_file_contents": true,
     "max_one_statement": true,

diff --git a/src/zcl_abapgit_tran_to_bran.clas.abap b/src/zcl_abapgit_tran_to_bran.clas.abap
@@ -9,7 +9,7 @@ CLASS zcl_abapgit_tran_to_bran DEFINITION
 
     TYPES:
       BEGIN OF ty_stage,
-        comment TYPE zif_abapgit_definitions=>ty_comment,
+        comment TYPE zif_abapgit_git_definitions=>ty_comment,
         stage   TYPE REF TO zcl_abapgit_stage,
       END OF ty_stage .
     TYPES:
@@ -53,7 +53,7 @@ CLASS zcl_abapgit_tran_to_bran DEFINITION
       IMPORTING
         !iv_changed_by TYPE xubname
       RETURNING
-        VALUE(rs_user) TYPE zif_abapgit_definitions=>ty_git_user .
+        VALUE(rs_user) TYPE zif_abapgit_git_definitions=>ty_git_user .
     METHODS is_relevant
       IMPORTING
         !iv_main           TYPE devclass
@@ -84,7 +84,7 @@ CLASS zcl_abapgit_tran_to_bran IMPLEMENTATION.
     DATA(lt_changed) = determine_changed( iv_trkorr ).
 
     LOOP AT lt_changed INTO DATA(ls_changed).
-      DATA(ls_comment) = VALUE zif_abapgit_definitions=>ty_comment(
+      DATA(ls_comment) = VALUE zif_abapgit_git_definitions=>ty_comment(
         committer = determine_user_details( ls_changed-username )
         comment   = zcl_bg_factory=>get_transports( )->read_description( iv_trkorr ) ).