Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Generator: SHA between local and remote are always different #144

Closed
ed-holland opened this issue Sep 6, 2020 · 7 comments
Closed

Dependency Generator: SHA between local and remote are always different #144

ed-holland opened this issue Sep 6, 2020 · 7 comments
Assignees
@larshp

Comments

@ed-holland
Copy link
Collaborator

The Dependencies generated always show up as changed due to different SHA1 field

Environment:

  • Gitlab on Linux
  • SAP on Windows

image
@ed-holland
Copy link
Collaborator Author

Debug Details:
image
Data Details (same):
image

@ed-holland ed-holland mentioned this issue Sep 6, 2020
Closed
@larshp
Copy link
Member

larshp commented Oct 19, 2020

Program name = ZABAPLINT_DEPENDENCIES ?

@larshp
Copy link
Member

larshp commented Oct 19, 2020

issue reproduced

@ed-holland
Copy link
Collaborator Author

Yes, that is the program used.

@larshp
Copy link
Member

larshp commented Oct 19, 2020

issue: after serialization, the file content is changed, but the SHA1 is not recalculated

@larshp larshp self-assigned this Oct 19, 2020
larshp added a commit that referenced this issue Oct 19, 2020
@larshp
recalculate local SHA1
3b439b0 
closes #144
@larshp
Copy link
Member

larshp commented Oct 19, 2020

fix added to PR #218

@ed-holland ed-holland mentioned this issue Oct 19, 2020
Merged
@ed-holland
Copy link
Collaborator Author

Tested PR. Issue is gone. Thx.

@larshp larshp closed this as completed in 59e359b Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larshp larshp

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larshp @ed-holland