2.8.24: bugfix, integer rounding from char (#1432)

package.json

@@ -189,10 +189,10 @@
         "@abaplint/core": "^2.106.5",
         "@types/chai": "^4.3.14",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.12.3",
+        "@types/node": "^20.12.7",
         "@types/sql.js": "^1.4.9",
-        "@typescript-eslint/eslint-plugin": "^7.5.0",
-        "@typescript-eslint/parser": "^7.5.0",
+        "@typescript-eslint/eslint-plugin": "^7.6.0",
+        "@typescript-eslint/parser": "^7.6.0",
         "chai": "^4.4.1",
         "cross-fetch": "^4.0.0",
         "dotenv": "^16.4.5",
@@ -202,10 +202,10 @@
         "mocha": "^10.4.0",
         "pg": "^8.11.5",
         "pg-cursor": "^2.10.5",
-        "snowflake-sdk": "^1.10.0",
+        "snowflake-sdk": "^1.10.1",
         "source-map-support": "^0.5.21",
         "sql.js": "^1.10.2",
-        "temporal-polyfill": "^0.2.3",
-        "typescript": "^5.4.3"
+        "temporal-polyfill": "^0.2.4",
+        "typescript": "^5.4.5"
     }
 }

packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.8.23",
+  "version": "2.8.24",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,15 +26,15 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.8.23",
+    "@abaplint/transpiler": "^2.8.24",
     "@types/glob": "^8.1.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.7",
-    "@types/node": "^20.12.3",
+    "@types/node": "^20.12.7",
     "@abaplint/core": "^2.106.5",
     "progress": "^2.0.3",
     "webpack": "^5.91.0",
     "webpack-cli": "^5.1.4",
-    "typescript": "^5.4.3"
+    "typescript": "^5.4.5"
   }
 }

packages/runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/runtime",
-  "version": "2.8.23",
+  "version": "2.8.24",
   "description": "Transpiler - Runtime",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -34,9 +34,9 @@
     "chai": "^4.4.1",
     "mocha": "^10.4.0",
     "source-map-support": "^0.5.21",
-    "typescript": "^5.4.3"
+    "typescript": "^5.4.5"
   },
   "dependencies": {
-    "temporal-polyfill": "^0.2.3"
+    "temporal-polyfill": "^0.2.4"
   }
 }

packages/runtime/src/types/integer.ts

@@ -25,7 +25,7 @@ export function toInteger(value: string, exception = true): number {
       throw new Error("CONVT_NO_NUMBER");
     }
   }
-  return parseInt(value, 10);
+  return Math.round(parseFloat(value));
 }
 
 export class Integer implements INumeric {

packages/transpiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.8.23",
+  "version": "2.8.24",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -38,6 +38,6 @@
     "chai": "^4.4.1",
     "mocha": "^10.4.0",
     "source-map-support": "^0.5.21",
-    "typescript": "^5.4.3"
+    "typescript": "^5.4.5"
   }
 }

test/types/integer.ts

@@ -150,4 +150,26 @@ describe("Running Examples - Integer type", () => {
     await f(abap);
     expect(abap.console.get()).to.equal("FFEF6E");
   });
+
+  it("rounding from char, up", async () => {
+    const code = `
+    DATA lv_date_int TYPE i.
+    lv_date_int = '45141.58832'.
+    WRITE / lv_date_int.`;
+    const js = await run(code);
+    const f = new AsyncFunction("abap", js);
+    await f(abap);
+    expect(abap.console.get()).to.equal("45142");
+  });
+
+  it("rounding from char, down", async () => {
+    const code = `
+    DATA lv_date_int TYPE i.
+    lv_date_int = '45141.48832'.
+    WRITE / lv_date_int.`;
+    const js = await run(code);
+    const f = new AsyncFunction("abap", js);
+    await f(abap);
+    expect(abap.console.get()).to.equal("45141");
+  });
 });