-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Half up rounding not done for integer = '45141.58832' (actual: 45141, expected: 45142) #1431
Comments
thanks, note its not a required check in abap2xlsx, also feel free to ping me in the PR if it fails looking into it now |
Oh I didn't realize it was optional, no hurry so. Thank you. |
@sandraros try again, 2.8.24 published I've also opened abap2xlsx/abap2xlsx#1207 |
It's now okay, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a failure with abap2xlsx unit test (see the log corresponding to the pull request abap2xlsx/abap2xlsx#1197).
Probably, it's related to this code:
and zcl_excel_common=>excel_string_to_date:
The code which should be executed is
lv_date_int = ip_value
, where ip_value = '45141.58832'. I guess that the transpiler calculates45141
, but it should calculate45142
.Thank you.
The text was updated successfully, but these errors were encountered: