Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for song lyrics #20

Closed
thenktor opened this issue Sep 16, 2010 · 7 comments
Closed

Search for song lyrics #20

thenktor opened this issue Sep 16, 2010 · 7 comments

Comments

@thenktor
Copy link

Hi,
when I'm listening to music on my couch I'm often interested in the song lyrics. So some button that automatically searches for >"artist name" "song name" lyrics< on Google would be nice.

@abarisain
Copy link
Owner

Oh, thought about implementing an embeeded lyrics viewer but gave up. Didn't have that idea, which is nice (not as nice as embeeding lyrics but still !)

I will do it :)

@thenktor
Copy link
Author

Embedding would be cool, but opening the standard browser with search results is a good beginning ;)

@bigpresh
Copy link

If you do decide to embed a lyrics viewer, I run www.lyricsbadger.co.uk which fetches lyrics from a variety of sources, and could provide a simple API for you to call, so you'd not have to worry about the actual fetching, just a straight HTTP call to get them.

@thenktor
Copy link
Author

thenktor commented Oct 6, 2012

push ;-)

@abarisain
Copy link
Owner

Sorry, I have a lot of stuff to fix (and some other projects to work on !) since the new release. Lyrics is on the roadmap :)

@ferdnyc
Copy link

ferdnyc commented Nov 20, 2012

If you do end up embedding lyrics at any point, tie-ins to @bigpresh 's lyricsbadger (and/or other services) are obviously the main draw, but local-server lyrics support would be nice to have too. Especially since local-server cover art is already supported.

I'd been using gmpc's local-path loading, until they switched to glyr and it stopped working right for me. (gmpc looked for a file named ${filepart}.lyric in the same directory as ${filepart}.mp3/ogg/etc, if it was configured with the local path of the mpd music directory.) Having MPDroid make the same request to the "cover-art" webserver to pull lyrics would be fairly trivial, and a nice feature to have. In fact, in some ways it would be superior to the gmpc method, whic required that the mpd server's music directory be visible/mounted on the machine running gmpc. (I found that it mostly worked over my gvfs/fuse sftp:/// connection to the server... until it didn't.)

Warning, Uninteresting Personal Backstory Follows

The bulk of my mpd library consists of DJ sets, so it's full of multi-hour "songs" consisting of several, sometimes dozens of, tracks. Since those tracklistings are often available, and it's nice to associate them with the mixes where possible, I'd taken to overloading mpd's "lyrics" feature to catalog tracklists. But, because none of the "songs" actually are, no lyrics server is going to return the proper info if queried — in fact, they shouldn't return any info, and only do in rare instances where the file is poorly tagged and collides with an artist's released work.

@abarisain abarisain mentioned this issue Feb 21, 2014
@avuton avuton self-assigned this Apr 12, 2015
@avuton
Copy link
Contributor

avuton commented Apr 12, 2015

Fixed via 94fec96.

@avuton avuton closed this as completed Apr 12, 2015
@avuton avuton mentioned this issue Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants