New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luminosity unit conversion obs_bandwidth #14
Comments
@telegraphic The error when using units on As for the average luminosity, I have a beta version of a |
I've just been dividing energy by width ;) Wael just reminded me that in the Zhang (2018) paper they picked up that central observing frequency nu should be used instead of obs_bandwidth to estimate isotropic energy (I'm checking some of his calculations against fruitbat!):
|
So are you suggesting that both |
Yes, that's my understanding, they suggest that |
What I am going to do is use |
* Added a `calc_luminosity()` function that takes a parameter `use_bandwidth` to choose between bandwidth and central observing frequency. * Modified `calc_energy()` to now use `obs_freq_central` by default instead of `obs_bandwidth` * Added checks on units passed to Frb. If the units are incompatible it will return an error, otherwise it with use the units specified rather than the default. * Added tests for new luminosity and energy functions. * Added tests for correct and incorrect units in Frb.
The pull request #16 updating to version 0.2.1 has the luminosity function and passing units updates. You can use the I also made it possible to pass values with astropy units when calling If this works as you expect let me know and I can close this issue. |
I'm closing this issue based on talking to you in person, the issue seems resolved. |
Hey, was playing with luminosity conversion and I'm getting a unit error:
But with units on obs_bandwidth:
Also - smallish feature request: compute average luminosity in ergs/s
The text was updated successfully, but these errors were encountered: