Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last updated is after published!? #33

Closed
hannesm opened this issue Apr 24, 2016 · 1 comment · Fixed by #43
Closed

last updated is after published!? #33

hannesm opened this issue Apr 24, 2016 · 1 comment · Fixed by #43

Comments

@hannesm
Copy link
Collaborator

hannesm commented Apr 24, 2016

how can this happen: Published: 2016-04-24 (last updated: 2016-04-22)? (on https://hannes.nqsb.io/Posts/nqsbWebsite [when there was only a single commit touching (adding) the post, no updates yet])...
abbysmal added a commit that referenced this issue Apr 25, 2016
@abbysmal
Change how last_updated_commit_id is implemented
70cef0f 
The previous implementation was slow and clunky, this one is way faster (because it avoid running through the complete history graph) and *shoulb* be less clunky.
It has been tested successfully on various huge repositories (such as GHC) with various weird cases, but I'm not sure it is 100% perfect.
Either way, this should work better than the current one.
Fixes #33
@abbysmal
Copy link
Owner

This is weird and related to the clunky implementation of last_updated_commit.
This implementation was slow and I wasn't sure it was correct. I wrote some weeks ago a less clunky implementation, but wasn't sure it was 100% correct. (tested it quickly on huge repo with weird merges, like GHC, and it looked fine.)
At least it fixes your problem :)
capture d ecran 2016-04-25 a 10 48 44

hannesm pushed a commit to hannesm/Canopy that referenced this issue Apr 25, 2016
@abbysmal @hannesm
Change how last_updated_commit_id is implemented
36b8cc4 
The previous implementation was slow and clunky, this one is way faster (because it avoid running through the complete history graph) and *shoulb* be less clunky.
It has been tested successfully on various huge repositories (such as GHC) with various weird cases, but I'm not sure it is 100% perfect.
Either way, this should work better than the current one.
Fixes abbysmal#33
This was referenced May 4, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix timestamps from git hannesm/Canopy
2 participants
@abbysmal @hannesm