Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCID: Support for Get and Set Parameters #135

Conversation

kidbomb
Copy link

@kidbomb kidbomb commented Jul 22, 2018

This push request add support for 2 USB CCID messages:

  • GetParameters
  • SetParameters

@kidbomb
Copy link
Author

kidbomb commented Jul 22, 2018

The CCID layer is already mature at this point, so as far as applications are concerned, I believe we could merge it to the main branch now. However, I still intend to add some basic support for ISO7816 into the demos, and that could take a while. I plan to do this incrementally, and I already have some basic functionality at place, which I will create a pull request for as soon as this first PR got approval.

@abcminiuser
Copy link
Owner

(Yes, late again! No energy these days...)

Looks good, just some minor formatting that I'll fix up. Let's get this merged and cleaned and then we can do final merge checks before shoving it in master.

@abcminiuser abcminiuser merged commit f1b06c5 into abcminiuser:feature-ccid Aug 6, 2018
@abcminiuser
Copy link
Owner

Ok, did a little cleanup. Last round I think - double check the branch state and I'll create the final merge request.

@kidbomb kidbomb deleted the feature-ccid-get-set-parameters branch August 6, 2018 18:01
@kidbomb
Copy link
Author

kidbomb commented Aug 6, 2018

The branch looks good - I'll double check today by running the tests and as soon as it is done I'll let you know.

@kidbomb
Copy link
Author

kidbomb commented Aug 7, 2018

Tests looks good - let's merge it to master then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants