Use unique webpack jsonp function names per-project #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colingourlay
requested review from
nathanhoad,
louisstow,
phocks,
drzax,
will-fagerstrom and
Milliners-Son
drzax
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack uses jsonp to track its dynamic loading of chunks in multi-file packages, and by default uses the same global function name for its callback.
This creates problems when multiple webpack-built multi-file projects are running in the same page (for example, Presentation Layer + Odyssey). All projects that execute after the first are unable to let webpack know that their chunks have loaded because their status updates to the first app (which is unaware of other projects).
This change to aunty's default webpack config factors the package name into the jsonp function name, which should ensure that apps don't step on each others toes, and get all the callbacks they expect.