Mock PL events dev convenience method #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colingourlay
reviewed
Nov 1, 2022
src/index.ts
Outdated
| function decoyEventMockHandler({ detail }: DecoyEvent) { | ||
| if (detail.active === true) { | ||
| window.dispatchEvent( | ||
| new CustomEvent<DecoyEventDetail>('decoyActive', { |
There was a problem hiding this comment.
We can use the PresentationLayerCustomEvents enum here, instead of the string
colingourlay
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an addition to add a convenience method for mocking PL events while working in dev (see README.md) and ended with a revamp of the build process which I've bundled in this PR.
The size-limit check is failing because it's failing on main, not in this branch. So merging should fix that for future PRs too.