Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ABC Life application detection #3

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Remove ABC Life application detection #3

merged 2 commits into from
Mar 9, 2021

Conversation

colingourlay
Copy link
Contributor

This is technically a breaking change, but seeing as the removed components were never used..... 🤷‍♂️

@colingourlay colingourlay self-assigned this Jun 24, 2020
Copy link
Member

@phocks phocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadface

@drzax
Copy link
Member

drzax commented Jun 24, 2020

Ouch...too soon buddy.

@drzax
Copy link
Member

drzax commented Mar 8, 2021

There'll be an upcoming breaking change for requestDOMPermit changes, so we should roll this into that.

@drzax drzax added this to the 3.0.0 milestone Mar 8, 2021
* master:
  Return decoyed elements where possible and reject on timeout
  Handle arbitrary number of decoy activations
  Give memoize a generic type
  Update dependencies
  Add environment detection
  2.1.2
  Don't assume we have a 2nd child node
  Include ABC Everyday application in getApplication docs.
  Clarify in README that decoy keys can be any [a-z] string, and that multiple decoys can be activated as a result of a single `requestDOMPermit`. Retain the `DECOY_KEYS` enum as a list of known keys but relax the type restrictions on key arguments from `DECOY_KEYS` to `string`.
  2.1.1
  Add ABC Everyday application to README
  Change PL's partial hostname for preview tier detection, to include feature branches which don't have "preview." in their hostnames
  Add Presentation Layer's ABC Everyday application
  2.1.0
  Update dependencies
  Add whenOdysseyLoaded promise
@drzax drzax merged commit 087574e into master Mar 9, 2021
@drzax drzax deleted the lifeless branch March 9, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants