Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent #mark tags with no values take on value from previous #mark? #4

Closed
phocks opened this issue Apr 3, 2019 · 2 comments
Closed
Assignees

Comments

@phocks
Copy link
Member

phocks commented Apr 3, 2019

This might be a feature not a bug perhaps??? But...

#scrollyteller
This is the change in global temperature since 1910.
As you can see there has been a pretty drastic increase in temperature.
#mark
But what about in your lifetime?
#markTRIGGERfade
...
#mark
....
#markTESTvalue
This is what's happened in your life. From 1978 to 2018.
#mark
But what does this mean?
#endscrollyteller

Produces this in console when we scroll down

{piecemeal: false}
{piecemeal: false}
{trigger: "fade", hash: "TRIGGERfade", piecemeal: false}
{trigger: "fade", hash: "TRIGGERfade", piecemeal: false}
{test: "value", hash: "TESTvalue", piecemeal: false}
{test: "value", hash: "TESTvalue", piecemeal: false}

When I would have expected it to produce

{piecemeal: false}
{piecemeal: false}
{trigger: "fade", hash: "TRIGGERfade", piecemeal: false}
{piecemeal: false}
{test: "value", hash: "TESTvalue", piecemeal: false}
{piecemeal: false}

Anyway I just thought I'd log it here for discussion. It's not really a problem, just thought it was odd.

@phocks phocks added the bug Something isn't working label Apr 3, 2019
@phocks
Copy link
Member Author

phocks commented Apr 3, 2019

Note: yes this is easily fixed by making sure you put a value on the #mark

@nathanhoad
Copy link
Contributor

This is intended behavior. Unless you explicitly specify config for a marker it will assume the config from the previous marker still stands. It is copied to make referencing values simpler (removing the need to manually work out what the previous marker was at run time).

@nathanhoad nathanhoad removed the bug Something isn't working label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants