Early return in utils if node does not have tagName #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any node between the first and the last nodes of the scrollyteller is followed by text, or whitespace (like a carriage return) the call to nextSibling returns a Text node is which does not have a `tagName` property, and does have a `querySelectorAll` method. When `querySelectorAll` is called, in the changes introduced in commit 0a43e75 the text nodes cause an exception like this: ``` TypeError: s.querySelectorAll is not a function ``` The inability to have newlines between nodes, makes it very difficult to configure panel node markup as all the panels have to be on the same line. It might be better to only reject if node does not respond to `querySelectorAll`. I'm not sure if a Text node is valid as a scrollyTeller panel node.
nathanhoad
approved these changes
Aug 27, 2018
|
Thanks @noweverywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any node between the first and the last nodes of the scrollyteller is
followed by text, or whitespace (like a carriage return) the call to
nextSibling returns a Text node which does not have a
tagNameproperty, and does have a
querySelectorAllmethod.When
querySelectorAllis called, in the changes introduced in commit0a43e75 the text nodes cause an exception like this:
The inability to have newlines between nodes, makes it very difficult to
manually write markup as all the marks have to be on the same
line.
It might be better to only reject if node does not respond to
querySelectorAll. I'm not sure if a Text node is valid as ascrollyTeller panel node.