Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue after using setAttributes function #2

Closed
canaryDev41 opened this issue Dec 30, 2021 · 2 comments
Closed

issue after using setAttributes function #2

canaryDev41 opened this issue Dec 30, 2021 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@canaryDev41
Copy link

setAttributes() replaced the old array attributes and set the new one.


 /**
    * @return $this
*/
 public function setAttributes(array $attributes)
{
      $this->attributes = $attributes;
      return $this;
}

it should append the new attributes in the array not replace them.

@AbdallaMohammed AbdallaMohammed added bug Something isn't working good first issue Good for newcomers labels Dec 30, 2021
@AbdallaMohammed AbdallaMohammed self-assigned this Dec 30, 2021
@AbdallaMohammed
Copy link
Owner

Thank you for reporting this bug, I fixed that and I created new methods I hope those methods help you in your upcoming project. Have a nice day!

v1.2.0

@canaryDev41
Copy link
Author

Thanks for the effort, appreciated bro 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants