Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Animate progress bar on mount, update demo #21

Closed
wants to merge 6 commits into from

Conversation

lsanwick
Copy link
Contributor

@lsanwick lsanwick commented Mar 22, 2018

Builds on top of #21

The progress bar would not animate on the initial mount of the component because no CSS transition would occur (the bar starts at the specified width). This adds handling to start the bar at 0 and transition to the passed in completed value.

I've also updated the code for the demo to work correctly and added a script to build the demo, build-demo. I don't know how this gets published to GitHub Pages, but that would need to be done after rebuilding the demo code.

@coveralls
Copy link

coveralls commented Mar 22, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1c747e4 on lsanwick:ls/animation-fix into 4d6928a on abdennour:master.

@lsanwick
Copy link
Contributor Author

@abdennour any chance you can review this?

@abdennour
Copy link
Owner

Hello @lsanwick sorry for the delay in getting back to you

@lsanwick
Copy link
Contributor Author

No worries, thanks for taking a look!

@lsanwick
Copy link
Contributor Author

@abdennour Can you look at this now? I've rebased it against the current master branch. Not sure how the demo gets published, so that build product might need to be ignored.

@lsanwick lsanwick closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants