Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target detection for Windows ARM64EC #105

Merged
merged 2 commits into from Jan 6, 2024
Merged

Fix target detection for Windows ARM64EC #105

merged 2 commits into from Jan 6, 2024

Conversation

kobykahane
Copy link
Contributor

@kobykahane kobykahane commented Jan 5, 2024 •
edited

  • Treat MSVC ARM64EC as an ARM64 target.
  • Don't try setting various '-march' options for ARM64 on MSVC, where the switch does not apply.

With the accompanying changes in weidai11/cryptopp#1257, this enables building CryptoPP for Windows ARM64EC with cryptopp-cmake.

@kobykahane
Copy link
Contributor Author

CI workflow failures appear to be caused by the issue described in weidai11/cryptopp#1240 and unrelated to this PR.

@abdes abdes merged commit d1ed40b into abdes:master Jan 6, 2024
@abdes
Copy link
Owner

abdes commented Jan 6, 2024

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kobykahane @abdes