Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv: add additional csv builder settings #18

Merged

Conversation

ernestas-poskus
Copy link
Contributor

Hey,

Thank you for this crate, it came in handy!

My use case requires mingling with QuoteStyle::Always setting and flexible which are not accessible via the current builder. Adding all settings supported by csv crate, I have left the original function new( unchanged, so it does not become a breaking change.

@ernestas-poskus ernestas-poskus force-pushed the csv/add_additional_csv_settings branch from 0ce06e8 to 06427df Compare May 30, 2023 18:27
Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions!

@abdolence abdolence merged commit f4cc05d into abdolence:master May 30, 2023
@ernestas-poskus ernestas-poskus deleted the csv/add_additional_csv_settings branch May 31, 2023 06:50
@abdolence
Copy link
Owner

abdolence commented Jul 14, 2023

It seems I totally forgot to release after this PR, sorry.
Now this is available in https://github.com/abdolence/axum-streams-rs/releases/tag/v0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants