Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit null value serialization for timestamps #145

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix explicit null value serialization for timestamps #145

merged 1 commit into from
Dec 1, 2023

Conversation

emanon001
Copy link
Contributor

@emanon001 emanon001 commented Dec 1, 2023 •
edited

#[serde(with = "firestore::serialize_as_null_timestamp")] will not serialize None to null.

abdolence
abdolence approved these changes Dec 1, 2023
View reviewed changes
Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@abdolence abdolence merged commit da4d802 into abdolence:master Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdolence abdolence abdolence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emanon001 @abdolence