Tidy/minor code changes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move quota_project_id lookup to type declaration location in order to make control flow cleaner - use more functional, less verbose syntax
i10416
commented
Jan 4, 2024
| )) | ||
| })?; | ||
| match &url_creds.format { | ||
| None | Some(ExternalCredentialUrlFormat::Text) => Ok(response.text().await?.into()), |
There was a problem hiding this comment.
We can merge None case and Some(Text) case in one clause.
i10416
commented
Jan 4, 2024
| })?; | ||
| let json_object = json.as_object().ok_or_else(|| { | ||
| match &url_creds.format { | ||
| None | Some(ExternalCredentialUrlFormat::Text) => Ok(file_content.into()), |
There was a problem hiding this comment.
i10416
commented
Jan 4, 2024
| @@ -18,6 +18,16 @@ pub enum Credentials { | |||
| ExternalAccount(ExternalAccount), | |||
| } | |||
|
|
|||
| impl Credentials { | |||
| pub(crate) fn quota_project_id(&self) -> Option<&str> { | |||
There was a problem hiding this comment.
I usually put this kind of field access in struct impl section.
i10416
commented
Jan 4, 2024
| @@ -166,7 +176,7 @@ mod jwt { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, serde::Serialize, serde::Deserialize)] | |||
There was a problem hiding this comment.
No need to derive Deserialize.
remove unused derives from private structs and enums
i10416
force-pushed
the
tidy/minor-code-changes
branch
from
03cb9d2
to
784930b
Compare
abdolence
approved these changes
Jan 4, 2024
i10416
added a commit
to i10416/gcloud-sdk-rs
that referenced
this pull request
Jan 5, 2024
follow up abdolence#118
abdolence
pushed a commit
that referenced
this pull request
Jan 8, 2024
* tidy: remove duplicated code follow up #118 * chore: fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes some codes that I found are a bit verbose and complex without changing their logic.