Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x264 support in .aar target #4

Merged
merged 27 commits into from
Apr 8, 2024
Merged

x264 support in .aar target #4

merged 27 commits into from
Apr 8, 2024

Conversation

abe-winter
Copy link
Owner

@abe-winter abe-winter commented Mar 7, 2024

Do not merge

Working artifact

What changed

  • android builds previously had no StreamConfig. Now they have one with just video (no audio)
  • moved android-related make commands to new android.make
  • add separate droid-rdk.*.aar outputs for amd64 and arm64. needed this for the linker to work, but could be useful to release single-platform APKs at some point (they're 100mb instead of 200mb)
  • build-x264.sh for creating arm + x86 libx264.so
  • robot/web changes -- graphviz factored out of web_c.go, other flagging changes. when we merge to upstream, I will probably apply this as a separate change to make review easier.

Why

Streaming support

Cleanup + notes

  • the no_cgo flag changes should be merged soonish to upstream -- copying functions like this gets stale quickly
  • commented vars in android.make + build-x264.sh -- may need some of this to build on mac
  • no_cgo now has a lot of cgo. that's okay (android is the only user for now)
  • entrypoint_*.go has too many variants, we can significantly reduce I suspect -> remove windows, merge linux + unix
  • remove server-android + NDK_ROOT from android.make once RDK CI can build the AAR (don't need the full APK to run on every build though)

@abe-winter abe-winter marked this pull request as draft April 4, 2024 23:32
@abe-winter
Copy link
Owner Author

converted to draft while I merge droid-apk into this

Copy link
Collaborator

@seanavery seanavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested that x264 encoder factory setup is working on Android.
  • Livestream pipeline from rdk to app successful.

@abe-winter abe-winter marked this pull request as ready for review April 8, 2024 21:56
@abe-winter abe-winter merged commit 5e56c1e into droid-apk Apr 8, 2024
@abe-winter abe-winter deleted the droid-x264 branch April 8, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants