タブアイテムの最小幅を設定できるようにした #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangnux
reviewed
Mar 13, 2024
Sources/SwipeMenuView.swift
Outdated
| @@ -91,6 +91,9 @@ public struct SwipeMenuViewOptions { | |||
| /// TabView adjust width or not. Defaults to `true`. | |||
| public var needsAdjustItemViewWidth: Bool = true | |||
|
|
|||
| /// TabView item minimum width. | |||
| public var minimumItemWidth: CGFloat = 64.0 | |||
There was a problem hiding this comment.
デザイン上、ミニマム64ptで固定なのでこのままでも良い気がしたんですがどうでしょうか？
それかOptionalにするかとかですかね？
There was a problem hiding this comment.
あと、Item向けのサイズ制限ので、定義自体はItemView配下に入れた方が良いですね？
There was a problem hiding this comment.
デザイン上、ミニマム64ptで固定なのでこのままでも良い気がしたんですがどうでしょうか？
それかOptionalにするかとかですかね？
あっ、そもそもミニマム64ptで固定するのはジャンル選択タブのみの認識です、
今後他のUseCasもあるかもので、デフォルト値を0にして利用側に64を固定して良いかと思います。
kangnux
reviewed
Mar 13, 2024
| @@ -21,6 +21,10 @@ public struct SwipeMenuViewOptions { | |||
| /// ItemView width. Defaults to `100.0`. | |||
| public var width: CGFloat = 100.0 | |||
kangnux
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応内容
タブアイテムの最小幅をデフォルトで64ptに設定
スクショ