issues while packaging for bioconda #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm packaging RogueNaRok for bioconda because it is a requirement for another program I'm packaging. I ran into two issues which are easy enough to patch for bioconda, but which I thought might be worth contributing back upstream as well.
-fcommonto-fno-common. This causesmultiple definitionerrors when linking RogueNaRok. The easy fix was to add-fcommontoCFLAGS.abort()instead ofexit(0)when given the-hflag, leading toAborted (core dumped). This may be confusing for users who think something is going wrong, and it also makes it hard to make minimal tests that all programs can be executed. I changed the behavior toexit(0).