Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drag drop doesn't work #82

Closed
PaulBravey opened this issue Jun 30, 2017 · 1 comment · Fixed by #83
Closed

drag drop doesn't work #82

PaulBravey opened this issue Jun 30, 2017 · 1 comment · Fixed by #83
Assignees
@UncleDave
Labels
bug
Milestone
v0.6.5

Comments

@PaulBravey
Copy link

PaulBravey commented Jun 30, 2017 •
edited
Loading

The file drag and drop doesn't work with the default extensions due to the fact that the default is 'image/' and then the image-upload.component prefixes that with 'image/' so when you drag a jpeg it compares the file.type 'image/jpeg' with 'image/image/' and doesn't match
@UncleDave UncleDave mentioned this issue Jun 30, 2017
Closed
@UncleDave
Copy link
Collaborator

You're quite right, good spot.

@UncleDave UncleDave added this to the v0.6.5 milestone Jun 30, 2017
@UncleDave UncleDave self-assigned this Jun 30, 2017
UncleDave added a commit that referenced this issue Jun 30, 2017
@UncleDave
fix(input): fixed extensions not working when not specified
1d4d19e 
fixes #82
@UncleDave UncleDave mentioned this issue Jun 30, 2017
Merged
UncleDave added a commit that referenced this issue Jun 30, 2017
@UncleDave
fix(input): fixed extensions not working when not specified (#83)
204ab16 
fixes #82
UncleDave pushed a commit that referenced this issue Jul 1, 2017
@aberezkin @UncleDave
chore(release): v0.6.5 (#86)
6260ee9 
* chore(changelog): added changelog process (#79)

Fixes #74

* chore(build): fix build getting stuck

* fix(dependencies): add http module to imports

Fixes #80

* fix(input): fixed extensions not working when not specified (#83)

fixes #82

* fix(output): emit onRemove when all files are cleared (#85)

fixes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UncleDave UncleDave

Labels
bug
Projects
None yet
Milestone
v0.6.5
Development

Successfully merging a pull request may close this issue.

fix(input): fixed extensions not working when not specified aberezkin/ng2-image-upload
2 participants
@PaulBravey @UncleDave