Add handling for backend error #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abersheeran Can I get a review for this PR? Thanks |
abersheeran
reviewed
Jul 8, 2024
| @@ -0,0 +1,3 @@ | |||
| # flake8: noqa: F401 | |||
| from .backend_connection import BackendConnectionException | |||
There was a problem hiding this comment.
I think we should put the exceptions in a file, it seems unnecessary to break them down for our codebase.
| @@ -37,6 +51,7 @@ def __init__( | |||
| *, | |||
| on_auth_error: Optional[Callable[[Exception], Awaitable[ASGIApp]]] = None, | |||
| on_blocked: Callable[[int], ASGIApp] = _on_blocked, | |||
| on_backend_error: Callable[[int], ASGIApp] = _on_backend_error, | |||
There was a problem hiding this comment.
The type hint here is incorrect.
| assert response.text == "custom 503 page" | ||
|
|
||
|
|
||
| def yourself_503(retry_after: int): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
exceptionfolder to store all the custom exception classescore.pyto catchBaseBackendExceptionon_backend_errortoRateLimitMiddleware, defaults to_on_backend_errorand can be modified by enduser by passing their custom functionRedisBackendto catch ConnectionError raised by redis and raise custom exception instead_on_backend_errorfunction.