fix(bytesToSize): Change it to return "0 Bytes" if bytes is 0

abetomo · Sep 29, 2021 · 2640d95 · 2640d95
1 parent b682de6
commit 2640d95
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/__tests__/google-drive-cleaner.js b/lib/__tests__/google-drive-cleaner.js
@@ -80,7 +80,7 @@ describe('GoogleDriveCleaner', () => {
 
   test('bytesToSize()', () => {
     const tests = [{
-      expected: 'n/a',
+      expected: '0 Bytes',
       actual: 0
     }, {
       expected: '10 Bytes',
@@ -97,6 +97,12 @@ describe('GoogleDriveCleaner', () => {
     }, {
       expected: '10.3 TB',
       actual: 1024 * 1024 * 1024 * 1024 * 10.3
+    }, {
+      expected: '0 Bytes',
+      actual: '0' // string
+    }, {
+      expected: '10 Bytes',
+      actual: '10' // string
     }]
     tests.forEach(test => {
       expect(googleDriveCleaner.bytesToSize(test.actual)).toBe(test.expected)

diff --git a/lib/google-drive-cleaner.js b/lib/google-drive-cleaner.js
@@ -72,7 +72,7 @@ class GoogleDriveCleaner {
   bytesToSize (bytes) {
     const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB']
     bytes = Number(bytes)
-    if (bytes === 0) return 'n/a'
+    if (bytes === 0) return '0 Bytes'
     const i = parseInt(Math.floor(Math.log(bytes) / Math.log(1024)), 10)
     if (Number.isNaN(i)) return i
     if (i === 0) return `${bytes} ${sizes[i]}`