Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calcomp Designmate plotter #61

Merged
merged 5 commits into from Oct 2, 2020
Merged

Add Calcomp Designmate plotter #61

merged 5 commits into from Oct 2, 2020

Conversation

ithinkido
Copy link
Contributor

@ithinkido ithinkido commented Sep 29, 2020

Page origin based on loading orientation

Page origin based on loading orientation need to be addressed
updated page layout
vpype/hpgl_devices.toml Show resolved Hide resolved
vpype/hpgl_devices.toml Show resolved Hide resolved
vpype/hpgl_devices.toml Outdated Show resolved Hide resolved
vpype/hpgl_devices.toml Outdated Show resolved Hide resolved
@abey79
Copy link
Owner

abey79 commented Sep 30, 2020

@ithinkido I've made a few comments on the settings.

Now, after extensive discussion with @jamescarruthers, I've come to the conclusion that in general, it will not be possible to cover all the possible cases of what the user might be fancying. I will be adding a new info setting (both at plotter and paper level) where human-readable instructions can be written. These instruction will be displayed when using vpype with the specific plotter/paper combination. With that said, my suggestion would be to drop the a3p/a3l idea, decide that a3 should be always loaded in portrait orientation (big margin along short side), add info = "A3 page must be loaded in portrait orientation", and get rid of a3l.

Would that make sense to you?

vpype/hpgl_devices.toml Outdated Show resolved Hide resolved
vpype/hpgl_devices.toml Outdated Show resolved Hide resolved
vpype/hpgl_devices.toml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abey79 abey79 merged commit 26aae01 into abey79:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants