Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the Norwegian translations #169

Merged
merged 8 commits into from Sep 7, 2019
Merged

Conversation

DandelionSprout
Copy link
Contributor

In particular, I added some strings that were missing from nb.po, in the hopes of alleviating the fact that the Norwegian Bokmål translation is not actually being used on https://www.ntppool.org at the time of writing, thus ensuring that whoever knows how to make that translation go live can do that.

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Jun 25, 2019

Having now done nb.po, join.html, configuration.html, and intro.html for the Bokmål translation, are there any more files that are mandatory to translate in order for the Bokmål translation to go live? There's a few more files in https://github.com/abh/ntppool/tree/master/docs/ntppool/en, but they seem to be pretty convoluted and rarely used, so I was hoping to skip those that weren't considered crucial.

@abh abh merged commit ec69ec1 into abh:master Sep 7, 2019
abh added a commit that referenced this pull request Sep 7, 2019
@abh
Copy link
Owner

abh commented Sep 7, 2019

This should show up on https://web.beta.grundclock.com/en/ in a little bit when the containers have rebuilt, etc. Will you let me know if it looks okay so I can enable it for the production site?

@DandelionSprout
Copy link
Contributor Author

It seems to be showing up pretty well there.

Upon inspection of the on-site implementation of my translation, I notice ~6 minor grammar errors that I most likely want to correct, and I hope to have enough time to do so in a few hours' time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants