-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adhere to TS and Markdown Style Guidelines #46
Conversation
Hey, thanks for the PR! What exact guidelines does this modify the code to adhere to? |
https://ts.dev/style/#syntax and https://google.github.io/styleguide/tsguide.html for TypeScript. https://google.github.io/styleguide/docguide/style.html for Markdown. |
Could you please update your branch with the latest commits in |
Done @ADawesomeguy. |
It seems that it isn't passing the ESLint rules. Is there any way you could have the code abide by the TS style guidelines while also passing the ESLint workflow? |
Huh looks like ESLint prefers tabs over spaces. That should be an easy fix. |
ESLint rules are just some of my personal preferences, if you would like to fix the code to adhere to it you can just run |
Could you please git checkout my PR and run ESLint on that and then merge it? I feel like that would be easier to implement as I don't have ESLint. Thanks. |
It seems that I don't have permission to edit this PR so I cannot. |
@abheekda1 I pushed some commits that should adhere to the ESLint standard. Could you please verify this? Thanks. |
Running checks. Thank you! |
Co-authored-by: Piyush Acharya <acharyapiyush1@outlook.com>
Makes code easier to read and contribute to. No code changes.