Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to TS and Markdown Style Guidelines #46

Merged
merged 6 commits into from
Jan 13, 2023

Conversation

VerisimilitudeX
Copy link
Contributor

@VerisimilitudeX VerisimilitudeX commented Oct 13, 2022

Makes code easier to read and contribute to. No code changes.

@VerisimilitudeX VerisimilitudeX changed the title Adhere to TS and Markdown Style Guidelines [MINOR] Adhere to TS and Markdown Style Guidelines Oct 13, 2022
@abheekda1
Copy link
Owner

Hey, thanks for the PR! What exact guidelines does this modify the code to adhere to?

@VerisimilitudeX
Copy link
Contributor Author

@abheekda1
Copy link
Owner

Could you please update your branch with the latest commits in master?

@VerisimilitudeX
Copy link
Contributor Author

VerisimilitudeX commented Oct 18, 2022

Done @ADawesomeguy.

@abheekda1
Copy link
Owner

It seems that it isn't passing the ESLint rules. Is there any way you could have the code abide by the TS style guidelines while also passing the ESLint workflow?

@VerisimilitudeX
Copy link
Contributor Author

Huh looks like ESLint prefers tabs over spaces. That should be an easy fix.

@abheekda1
Copy link
Owner

abheekda1 commented Oct 19, 2022

Huh looks like ESLint prefers tabs over spaces. That should be an easy fix.

ESLint rules are just some of my personal preferences, if you would like to fix the code to adhere to it you can just run yarn lint --fix or npm run lint --fix, which in this case is able to fix all the problems.

@VerisimilitudeX
Copy link
Contributor Author

VerisimilitudeX commented Oct 24, 2022

Could you please git checkout my PR and run ESLint on that and then merge it? I feel like that would be easier to implement as I don't have ESLint. Thanks.

@abheekda1
Copy link
Owner

It seems that I don't have permission to edit this PR so I cannot.

@VerisimilitudeX VerisimilitudeX changed the title [MINOR] Adhere to TS and Markdown Style Guidelines Adhere to TS and Markdown Style Guidelines Dec 24, 2022
@VerisimilitudeX
Copy link
Contributor Author

@abheekda1 I pushed some commits that should adhere to the ESLint standard. Could you please verify this? Thanks.

@abheekda1
Copy link
Owner

Running checks. Thank you!

Co-authored-by: Piyush Acharya <acharyapiyush1@outlook.com>
@abheekda1 abheekda1 self-requested a review January 13, 2023 03:53
@abheekda1 abheekda1 merged commit b0763f7 into abheekda1:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants