Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: WriteGear failed to exit with external audio source #259

Closed
3 tasks done
abhiTronix opened this issue Oct 24, 2021 · 1 comment · Fixed by #262
Closed
3 tasks done

Bug: WriteGear failed to exit with external audio source #259

abhiTronix opened this issue Oct 24, 2021 · 1 comment · Fixed by #262
Assignees
@abhiTronix
Labels
BUG 🐛 Vidgear api's error, flaw or fault SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
VidGear v0.2.3
Milestone
0.2.3

Comments

@abhiTronix
Copy link
Owner

Description

There's a bug in disable_force_termination logic which disables force termination, which is essential to stop video encoding safely when external audio source is used.

Acknowledgment

Environment

  • VidGear version: v0.2.2
  • Branch: testing
  • Python version: all
  • PiP version: all
  • Operating System and version: all

Expected Behavior

WriteGear should terminate normally

Actual Behavior

WriteGear Freezes forever until thread is killed manually.

Steps to reproduce

Example: https://abhitronix.github.io/vidgear/latest/gears/writegear/compression/usage/#using-compression-mode-with-live-audio-input
@abhiTronix abhiTronix added BUG 🐛 Vidgear api's error, flaw or fault BUG CONFIRMED ✅ Bug is confirmed! WORK IN PROGRESS 🚧 currently been worked on. labels Oct 24, 2021
@abhiTronix abhiTronix added this to the 0.2.3 milestone Oct 24, 2021
@abhiTronix abhiTronix self-assigned this Oct 24, 2021
@abhiTronix abhiTronix added this to To do issues in VidGear v0.2.3 via automation Oct 24, 2021
abhiTronix added a commit that referenced this issue Oct 25, 2021
@abhiTronix
🐛 WriteGear: Fixed bug in disable_force_termination logic which acc…
5feafb7 
…identally disables force termination. (Fixes #259)

- ⚗️ Introduced experimental python short-circuiting for handling logging.
- 🔊 Enabled logging for `check_WriteAccess` method in WriteGear, StreamGear and NetGear.
- 💡 Improved code comments.

Helper:
- 🐛 Fixed check_WriteAccess failing to recognize correct permission for writing the output file on windows platform. (Fixes #260)
- ⚡️ Implemented separate logic for Windows and *nix platforms.
- 🥅 Improved warnings and error handling in `check_WriteAccess`.
- 💥 `check_WriteAccess` will now throw error if writing directory not present.
- 🎨 Added logging parameter to `check_WriteAccess`.
- ➕ Added `stat` import.

Docs:
- 📝 Fixed bugs in WriteGear's Compression Mode with Live Audio Input example.
- 📝 Added warnings for properly formatting output_params when assigning external audio-source in WriteGear.

CI:
- 👷 Replaced `env` with `export` in ci_linux.yml.
- 👷 Replaced `bubkoo/needs-more-info@v1` with `wow-actions/needs-more-info@v1`.
@abhiTronix abhiTronix mentioned this issue Oct 27, 2021
Merged
6 tasks
@abhiTronix abhiTronix linked a pull request Oct 27, 2021 that will close this issue
Release VidGear Stable v0.2.3 #262
Merged
6 tasks
VidGear v0.2.3 automation moved this from To do issues to Done Oct 27, 2021
@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. labels Oct 27, 2021
@abhiTronix
Copy link
Owner Author

Successfully resolved and merged in commit 99ffcec

@abhiTronix abhiTronix removed the BUG CONFIRMED ✅ Bug is confirmed! label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhiTronix abhiTronix

Labels
BUG 🐛 Vidgear api's error, flaw or fault SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
No open projects
VidGear v0.2.3
Done
Milestone
0.2.3
Development

Successfully merging a pull request may close this issue.

Release VidGear Stable v0.2.3 abhiTronix/vidgear
1 participant
@abhiTronix