Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: Update the chunk size parameter in docs #359

Closed
4 tasks done
themagicalmammal opened this issue May 15, 2023 · 3 comments · Fixed by #365, #367 or #379
Closed
4 tasks done

[Docs]: Update the chunk size parameter in docs #359

themagicalmammal opened this issue May 15, 2023 · 3 comments · Fixed by #365, #367 or #379
Assignees
@abhiTronix
Labels
DOCS 📜 Issue/PR is related to vidgear docs. ENHANCEMENT ⚡ New Feature/Addition/Improvement SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! WORK IN PROGRESS 🚧 currently been worked on.
Projects
VidGear v0.3.1
Milestone
v0.3.1

Comments

@themagicalmammal
Copy link

Issue guidelines

Issue Checklist

  • I have searched open or closed issues for my problem and found nothing related or helpful.
  • I have read the Documentation and found nothing related to my problem.
  • I have gone through the Bonus Examples and FAQs and found nothing related or helpful.

Describe your Question

Cannot find chunk size for hls format? I tried -seg_duration but that doesn't seem to change the chunk size. I am trying to get it to 2.

Terminal log output(Optional)

No response

Python Code(Optional)

No response

VidGear Version

latest

Python version

3.10

Operating System version

Ubuntu 22.04

Any other Relevant Information?

No response
@themagicalmammal themagicalmammal added the QUESTION ❓ User asked about the working/usage of VidGear APIs. label May 15, 2023
@welcome
Copy link

welcome bot commented May 15, 2023

Thanks for opening this issue, a maintainer will get back to you shortly!

In the meantime:

  • Read our Issue Guidelines, and update your issue accordingly. Please note that your issue will be fixed much faster if you spend about half an hour preparing it, including the exact reproduction steps and a demo.
  • Go comprehensively through our dedicated FAQ & Troubleshooting section.
  • For any quick questions and typos, please refrain from opening an issue, as you can reach us on Gitter community channel.

@themagicalmammal
Copy link
Author

Found it -

"-hls_init_time": 2, "-hls_time": 2,

setting one of them doesn't fix it, for some reason have to set both of them. Please put this in the docs.

@themagicalmammal themagicalmammal changed the title [Question]: [Docs]: Update the chunk size parameter in docs May 16, 2023
@abhiTronix abhiTronix added ENHANCEMENT ⚡ New Feature/Addition/Improvement WORK IN PROGRESS 🚧 currently been worked on. DOCS 📜 Issue/PR is related to vidgear docs. and removed QUESTION ❓ User asked about the working/usage of VidGear APIs. labels May 16, 2023
@abhiTronix abhiTronix self-assigned this May 16, 2023
@abhiTronix abhiTronix added this to To do in VidGear v0.3.1 via automation May 16, 2023
@abhiTronix abhiTronix added this to the v0.3.1 milestone May 16, 2023
@abhiTronix abhiTronix linked a pull request Jul 5, 2023 that will close this issue
ScreenGear: Added support for DXcam backend on Windows (Fixes #316) #365
Merged
6 tasks
@abhiTronix abhiTronix mentioned this issue Jul 5, 2023
Merged
6 tasks
abhiTronix added a commit that referenced this issue Jul 6, 2023
@abhiTronix
✨ ScreenGear: Added support for DXcam backend on Windows (Fixes #316)
612dee0 
- 🎉 Added initial `dxcam` support for Windows machines.
  - ✨ Implemented a complete workflow for the `dxcam` backend.
  - 🏗️ `dxcam` is now the default backend for Windows machines.
  - ✨ Added support for tuple values in the monitor parameter to specify device and output indexes as `(int[device_idx], int[output_idx])` in the `dxcam` backend only.
    - 🧑‍💻 `int` index is also allowed as a value for selecting device index.
  - ⚡️ Added support for variable screen dimensions to capture an area from the screen.
  - 🚩 Added the optional flag `dxcam_target_fps` to control the target fps in `dxcam`. Defaults to `0` (disabled).
  - ⚡️ RGB frames from `dxcam` are automatically converted into BGR.
  - ⚡️ For better performance, `video_mode` is enabled by default.
  - ➕ Added necessary imports.
  - ♻️ Refactored code blocks to ensure backward compatibility.
  
- 💥 Enforced threaded queue mode is now completely removed, resulting in a potential performance boost.
  - 💬 Reason: The IO is automatically blocked by the screen refresh rate, so adding the overhead of maintaining a separate queue is pointless.
  - 💥 Removed the `THREAD_TIMEOUT` optional flag.
  - 🔥 Cleaned up unused imports and code blocks.
  - 🍻 Note: Multi-Threading is still available.

- 🏗️ Enforced `dxcam` backend (if installed) when `monitor` is defined on Windows machines.
- 🐛 Fixed backend not defined while logging.

Docs:
- 📝 Added docs for controlling Chunk size in HLS stream. (Fixes #359)
  - 🎨 Fixed context and added separate methods for controlling Chunk size in HLS and DASH streams.
- ⚡️ Updated docs for ScreenGear with respect to recent changes.
  - 🧑‍💻 Updated usage example docs, added new relevant information, updated requirements.
- ✨ Added `dxcam` API specific prerequisites for ScreenGear API when installing on Windows via pip.
- ♻️ Refactored `monitor` and `backend` parameters docs of ScreenGear API.
- 📝 Added a new description for ScreenGear API.
- 🗑️ Removed ScreenGear from Threaded Queue Mode docs.
- 🎨 Updated ScreenGear FAQs.
- ✨ Added new hyperlinks.
- 🔥 Cleaned redundant code.

Setup.py:
- ⬆️ Added `dxcam` dependency in `core` and `asyncio` extra requires.
- 📌 Pinned mss==7.0.1.
  - 🚑️ Starting from version `8.0.0`, the python-mss library dropped support for Python `3.7`, so as a temporary measure, it has been pinned to version `7.0.1`.

Helper: 
- ⚡️ Added multiple server support for downloading assets.
  - 🧑‍💻 Added GitHub server to the `generate_webdata` method to make it more robust for rate limits and other shortcomings.
    - 🩹 Now, the `generate_webdata` method will retry a different server when one fails.

Maintenance:
- 🗑️ Removed unused imports.
- 🎨 Implemented short-circuiting.
- 🔊 Improved logging.
- ✏️ Fixed comment typos.
- 💡 Updated comments.

CI: 
- 🐛 Fixed m3u8 module failing to recognize Windows paths in ScreenGear tests.
- 🚑️ Fixed a path bug by replacing the absolute file path with the decoded file content as a string in its `loads()` function.
@abhiTronix
Copy link
Owner

@themagicalmammal This issue has been fixed in commit: 612dee0, thanks for reporting.

VidGear v0.3.1 automation moved this from To do to Done Jul 6, 2023
@abhiTronix abhiTronix added the SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! label Jul 6, 2023
@abhiTronix abhiTronix linked a pull request Jul 9, 2023 that will close this issue
🎉 Release VidGear Stable v0.3.1 #367
Merged
6 tasks
@abhiTronix abhiTronix mentioned this issue Jul 9, 2023
Merged
6 tasks
@abhiTronix abhiTronix mentioned this issue Sep 10, 2023
Merged
7 tasks
@abhiTronix abhiTronix linked a pull request Sep 10, 2023 that will close this issue
🎉 Release VidGear Stable v0.3.2 #379
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhiTronix abhiTronix

Labels
DOCS 📜 Issue/PR is related to vidgear docs. ENHANCEMENT ⚡ New Feature/Addition/Improvement SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! WORK IN PROGRESS 🚧 currently been worked on.
Projects
No open projects
VidGear v0.3.1
Done
Milestone
v0.3.1
2 participants
@abhiTronix @themagicalmammal