🧑💻 Maintenance: Log current vidgear version when vidgear APIs are called, not at import. (Fixes #338) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled, not at import (Fixes #338) - ✨ Added `logcurr_vidgear_ver` helper function to facilitate logging current vidgear version, when called within a API. - 🔇 Implemented `ver_is_logged` global variable to log version only once, modifiable only with `logcurr_vidgear_ver`, and finally made it available in all APIs. - 🧑💻 Followed recommendation given in official python docs: https://docs.python.org/3/faq/programming.html#how-do-i-share-global-variables-across-modules - ⚡️ Current vidgear version can only be logged by APIs with its logging enabled. - 🔥 Removed unnecessary imports.
…ming `output` value as valid path. - 👷 Added v4l2loopback support for testing `/dev/video0` device on Linux machines. - ☂️ Increased coverage.
abhiTronix
added
ENHANCEMENT ⚡
4 tasks
Codecov ReportBase: 94.41% // Head: 94.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## testing #348 +/- ##
===========================================
+ Coverage 94.41% 94.65% +0.24%
===========================================
Files 16 16
Lines 3116 3125 +9
===========================================
+ Hits 2942 2958 +16
+ Misses 174 167 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abhiTronix
added
SOLVED 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR will add functionality to log current vidgear version once only when vidgear APIs are called, not at import. Less clutter in logs.
Requirements / Checklist
Related Issue
#338
#340
Context
This PR is aimed at reducing unnecessary logging of vidgear current version on importing its APIs. With this PR, user can now completely turn off logging and moreover APIs with logging turned on (
logging=True) will automatically log version only once when called within code, thus serving both purposes.Types of changes