⚡️Helper: Added more robust implementation of validate_audio method.
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ✨ Added `content.code.copy` and `content.tabs.link` features. - ✏️ Minor typos fixed.
Fixes #343) - ⚡️Updated `validate_audio` method with improved and more robust regex patterns for identifying audio bitrate in any audio file. - 🐛Fixed `fltp` keyword in regex pattern causing non-ftlp streams to be not recognized. - ⚡️Added new more robust regex pattern for extracting audio-samplerate. - ✨Added new `validate_audio` method for calculating accurate bitrate(in kbps) from audio samplerate, channels, bit-depth values. - ⚡️Implemented new patterns and logic for accurately extracting audio channels and bit-depth from given metadata. - 🐛 Fixed `validate_audio` returning wrong bitrate values for samplerate values less than `44100Hz`. - 🔥 Removed dead code.
- 🚚 Mirrored all assets to `gitlab.com` for smoother user-experience while accessing vidgear assets. - 🚸 Replaced all `raw.githubusercontent.com` URLs with `gitlab.com` URLs. - ✏️ Fixed typos in README.md. 👷 CI: Added test cases for newer implementation of `validate_audio` method.
- 🚑️ Fixed response.headers returning `content-length` as Nonetype since it may not necessarily have the Content-Length header set. - 💬 Reason: The response from gitlab.com contains a Transfer-Encoding field as `'Transfer-Encoding': 'chunked'`, which means data is sent in a series of chunks, so the Content-Length header is emitted. More info: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding#Directives - 🔊 Improved logging.
- 🚑️ Fixed response.headers returning `content-length` as Nonetype since it may not necessarily have the Content-Length header set. - 💬 Reason: The response from gitlab.com contains a Transfer-Encoding field as `'Transfer-Encoding': 'chunked'`, which means data is sent in a series of chunks, so the Content-Length header is emitted. More info: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding#Directives
abhiTronix
added
ENHANCEMENT ⚡
This was
linked to
issues
Jan 5, 2023
3 tasks
Codecov ReportBase: 94.66% // Head: 94.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## testing #350 +/- ##
===========================================
- Coverage 94.66% 94.66% -0.01%
===========================================
Files 16 16
Lines 3131 3130 -1
===========================================
- Hits 2964 2963 -1
Misses 167 167
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ab (Fixes #347) - 🚑️ Fixed DASH playback failing by setting the `maxAttempts` to Infinity. - 📝 Updated announcement bar and added minor tweaks to scripts. - 💄 Removed `x-sign` glow-text effect CSS.
- 🚑️ Fixed conditional logic to check file is downloaded properly. - 🚑️ Corrected Decrement Variable code in Bash. - ♻️ Removed unnecessary quotes.
abhiTronix
added
SOLVED 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR will bring more robust implementation of
validate_audiomethod with improved and more robust regex patterns for identifying audio bitrate in any audio file. Plus it will move/clone all assets from GitHub to GitLab.Requirements / Checklist
Related Issue
#343
#347
Context
This PR is aimed at improving regex patterns for identifying audio bitrate in any audio file and also moving/cloning all vidgear assets from GitHub to GitLab for smoother user-experience while accessing these assets.
Types of changes