Major enhancements and bugfixes #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🚩 Implemented new `kill` argument to `close()` method to forcefully kill ZMQ context instead of graceful exit only in the `receive` mode. - 🔊 Updated logging.
…d. (Fixes #372) - 🩹 Fixed "mss" backend disabled when `monitor` parameter is not defined. Stabilizer Class: - 🔥 Removed redundant code - ✏️ Fixed typos.
…ixes #372) - 📝 Updated information related to Supported Dimensional Attributes in ScreenGear docs. - ✏️ Fixed typos and context. - 🍱 Added new asset `screengear_region.png`. - 📄 Fixed missing `compression_mode` flags in WriteGear API docs.
…Fixes #374) - ✨ Added new `subscriber_timeout` integer optional parameter to support timeout with `pattern=2` or PUBLISHER-SUBSCRIBER pattern. - 🧑💻 Receiver will exit safely if timeout defined(any value(in milliseconds) > 0), and timeout occurs in Receiver Mode with `pattern=2`. - 🎨 Note: Default behavior still is to block the thread till infinite time. - 🔊 Updated logging.
- ✨ Added a new feature to enable detached subprocess creation on Windows within the WriteGear API. - 🧑💻 This enhancement enhances the process management capabilities of the module. - ♿️ Use Case: This can be useful while creating an exe file for a python script that uses WriteGear API. On windows even after creating the exe file in windowed mode or no-console mode, the ffmpeg.exe command line window would pop up while its being used by WriteGear API. - 🚩 Added new `ffmpeg_subprocess_creation_window` Boolean flag to enable this feature. - ⚡️This feature can be enabled both in logging and silent mode.
- ✨ Added new `-disable_ffmpeg_window` optional Boolean flag to enable patch that prevents FFmpeg creation window from opening when building .exe files on Windows OS. - ⚡️Note: Now `-disable_ffmpeg_window` optional Boolean flag is only available on Windows OS with logging disabled(`logging=False`) in compression mode. - 🚩 Removed `ffmpeg_subprocess_creation_window` class parameter. - 🥅 Disabled this patch for logging mode. - 🔥 Removed redundant code. - 🔊 Updated logging.
…ter in WriteGear.
…meter in WriteGear.
abhiTronix
added
BUG 🐛
This was
linked to
issues
Sep 4, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
abhiTronix
added
SOLVED 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR focuses on improving functionality, fixing bugs, enhancing documentation, and updating tests in the project, making it more robust and user-friendly.
Changes:
This PR includes a series of updates and improvements to different parts of the project:
NetGear Module Enhancement:
killargument to theclose()method to forcefully terminate the ZMQ context, primarily for use in thereceivemode.pattern=2in receiver_mode.subscriber_timeoutoptional integer parameter to specify a timeout for Receiver Mode withpattern=2.killargument.ScreenGear Module Bug Fix:
monitorparameter was not defined.Stabilizer Class Improvements:
WriteGear Module Enhancements:
disable_ffmpeg_windowoptional Boolean flag for this feature.Continuous Integration (CI) Updates:
subscriber_timeoutparameter in NetGear.disable_ffmpeg_windowoptional Boolean parameter in WriteGear.Documentation Improvements:
subscriber_timeoutparameter in NetGear.disable_ffmpeg_windowparameter in WriteGear.Requirements / Checklist
Related Issue
#361
#372
#374
#377
Context
These changes were required to enhance functionality, fix bugs, improve documentation, and ensure a smoother user experience when working with the project's modules and features. They address various issues and usability concerns that users might encounter during development and usage.
Types of changes