Avoid circular import issues. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiabhi94
requested changes
Mar 9, 2021
There was a problem hiding this comment.
Thank you for taking the time to contribute.
It would be nice if you could incorporate the changes requested on the specific lines.
In addition, it would be great if you could change the ones mentioned below as well. It will allow consistency throughout the codebase.`
Line 14 in f26ce46
abhiabhi94
requested changes
Mar 9, 2021
|
Also, could you please squash your commits into one? It will help us maintain a clean git history. |
abhiabhi94
requested changes
Mar 9, 2021
abhiabhi94
requested changes
Mar 10, 2021
|
could you please squash your commits into one? it will help us in maintaining a clean git history. |
|
can you update your branch with the latest changes from the |
- move call to get_user_model from a module level to function level in utils. - use settings.AUTH_USER_MODEL in models.
abhiabhi94
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django documentation recommends using settings.AUTH_USER_MODEL over get_user_model() when you define a foreign key or many-to-many relation to the user model.
https://docs.djangoproject.com/en/3.1/topics/auth/customizing/
helped fix a circular import issue in my project.