Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code functionality added #90

Closed
wants to merge 1 commit into from

Conversation

Ansh101112
Copy link

@Ansh101112 Ansh101112 commented May 17, 2024

Add QR Code Generation for Shortened URL

Description

This PR adds functionality to generate and display a QR code for the shortened URL after it is created. This enhancement improves user experience by providing an easy way to share the shortened URL via QR code.

Changes

  • Install qrcode.react library for QR code generation.
  • Update the Home component to include a QR code for the shortened URL.
  • Modify the state management to handle the shortened URL and display the QR code conditionally.

Issue Resolved

#32

Copy link

vercel bot commented May 17, 2024

@Ansh101112 is attempting to deploy a commit to the Abhijeet's projects Team on Vercel.

A member of the Team first needs to authorize it.

@abhijeetnishal
Copy link
Owner

Hey @Ansh101112, this PR doesn't contain any code

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented May 17, 2024

We discussed that we don't need to use external package for this because this can be done using canvas also.

@Ansh101112
Copy link
Author

We discussed that we don't need to use external package for this because this can be done using canvas also.

Okay will update it

@abhijeetnishal abhijeetnishal changed the title qr code functionality added #32 QR code functionality added May 17, 2024
@abhijeetnishal
Copy link
Owner

Hey @Ansh101112, are you working on this issue

@Ansh101112
Copy link
Author

Hey @Ansh101112, are you working on this issue

Yeah just give me 2 days

@abhijeetnishal
Copy link
Owner

Hey @Ansh101112, what's the progress?

@Ansh101112
Copy link
Author

Hey @Ansh101112, what's the progress?

Now started working on it am busy with another org work please understand and really sorry for delay.

@abhijeetnishal
Copy link
Owner

Hey @Ansh101112, what's the progress?

Now started working on it am busy with another org work please understand and really sorry for delay.

No problem. But the issue is other contributers didn't get chance to work.

@Ansh101112
Copy link
Author

Hey @Ansh101112, what's the progress?

Now started working on it am busy with another org work please understand and really sorry for delay.

No problem. But the issue is other contributers didn't get chance to work.

Hey @Ansh101112, what's the progress?

Now started working on it am busy with another org work please understand and really sorry for delay.

No problem. But the issue is other contributers didn't get chance to work.

Yeah sir I can understand just give me 2 more days for this issue to be resolved or you can assign to someone else after my deadline

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented May 28, 2024

Hey @Ansh101112, I guess I have given sufficient time more than 3 weeks. According to gssoc guidelines its max 1-2 week. Also this issue will be hardly take 2-3 hours.

I am closing this PR I will add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants