Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All colors are inverted? #45

Closed
Aditya94A opened this issue Jul 23, 2020 · 3 comments
Closed

All colors are inverted? #45

Aditya94A opened this issue Jul 23, 2020 · 3 comments
Labels
effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in this project type: question or discussion Issue discussing or asking a question

Comments

@Aditya94A
Copy link

Aditya94A commented Jul 23, 2020

image

For some reason, all website colors are inverted whenever I activate this boilerplate extension.

Just git pulled and loaded into the latest chrome, no other changes. It goes back to normal when I remove/disable this specific extension and I can't find any styles that lead to this. There's nothing else to attribute this to except this extension being loaded.

What's going on? Any ideas?

@abhijithvijayan
Copy link
Owner

The sample code(in ContentScripts) invert the color.

It was done for the demo, but I guess it causes more ambiguity.

@Aditya94A
Copy link
Author

Ahh! Just saw it. Yeah, that was a little jarring. Hehe, I think the icon appearing + popup/options etc. is enough evidence that the extension boilerplate works.

Anyone wanting to do more will inevitably stumble to official extension docs in which case they can figure out by themselves what contentscript can be used for.

I think this should be removed. Or commented.

@abhijithvijayan
Copy link
Owner

Nice catch @AdityaAnand1

I have removed the line from all 3 branches.

@abhijithvijayan abhijithvijayan added effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in this project type: question or discussion Issue discussing or asking a question labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in this project type: question or discussion Issue discussing or asking a question
Projects
None yet
Development

No branches or pull requests

2 participants