Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command bcrypt ignoring rounds-parameter #42

Closed
mueckl opened this issue May 25, 2024 · 3 comments
Closed

command bcrypt ignoring rounds-parameter #42

mueckl opened this issue May 25, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mueckl
Copy link

mueckl commented May 25, 2024

I'm using version 0.2.20

It seems the bcrypt subcommand ignores the "Number of rounds"-parameter and uses always it's default value (=10)


user@host:~$ bin/sttr version
0.2.20

user@host:~$ time echo foobar | bin/sttr bcrypt 
$2a$10$HPs11TyDOG9iXxghmQF/qeLbIkqlsl5FmHIqe7GhJzmEs9lsH2lHy
real	0m0,121s
user	0m0,110s
sys	0m0,019s
user@host:~$ time echo foobar | bin/sttr bcrypt -r 12
$2a$10$RpRFWm9NGNe2/usl.1LYZuVmDVK.0xuAI0kvCCHE0PN.IT8K3jRK.
real	0m0,130s
user	0m0,112s
sys	0m0,026s

user@host:~$ bin/sttr help bcrypt
Get the Bcrypt hash of your text

Usage:
  sttr bcrypt [string] [flags]

Aliases:
  bcrypt, bcrypt-hash

Flags:
  -h, --help                    help for bcrypt
  -r, --number-of-rounds uint   Number of rounds (default 10)


@mueckl mueckl changed the title command bycrypt ignring rounds-parameter command bycrypt ignoring rounds-parameter May 25, 2024
@mueckl mueckl changed the title command bycrypt ignoring rounds-parameter command bcrypt ignoring rounds-parameter May 25, 2024
@abhimanyu003 abhimanyu003 added the bug Something isn't working label May 26, 2024
@abhimanyu003
Copy link
Owner

Hello @mueckl
Many thanks for your report and detailed explanation. 🙇 🙏

This is fixed in 41d0dde

I will do a tag release soon.

@abhimanyu003
Copy link
Owner

Fixed in release https://github.com/abhimanyu003/sttr/releases/tag/v0.2.21

once again thanks so much.

@mueckl
Copy link
Author

mueckl commented May 27, 2024

That was quick - Thank you - Looks good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants