feat: Add extra param to waitForReact (#273) #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an extra optional param resqModulePath for bypassing the auto loader
|
@abhinaba-ghosh This was really the only way I was able to get webpack to play nicely with loading module paths at runtime. The readme for this change isn't updated as it's really just an escape hatch for using webpack. It is backwards compatible though and completely optional for the user. |
|
@ajhenry thanks for the PR. Amazing, that you have figured out the solution. 🏆 |
|
I added a small note in the readme 🚀 |
abhinaba-ghosh
approved these changes
Jan 20, 2022
|
Hi @ajhenry , the update is available in the version |
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra param to the
waitForReactfunction to directly input the path to the resq loader. This solves the issue with Webpack and allows arbitrary loading of different module resolution.Related issue #273