Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact protocol is encoding floating point numbers incorrectly #15

Closed
jacobstanley opened this issue Jun 1, 2017 · 2 comments
Closed

Compact protocol is encoding floating point numbers incorrectly #15

jacobstanley opened this issue Jun 1, 2017 · 2 comments

Comments

@jacobstanley
Copy link

jacobstanley commented Jun 1, 2017 •
edited

The compact protocol is supposed to encode doubles in little endian (THRIFT_htolell is host to little-endian) but this library is encoding them in big endian.
abhinav added a commit that referenced this issue Jun 1, 2017
@abhinav
compact: Fix encoding of doubles
4e7ebb5 
The compact protocol encodes doubles in little endian byte ordering, not
big endian.

Resolves #15
@abhinav abhinav mentioned this issue Jun 1, 2017
Merged
@abhinav
Copy link
Owner

abhinav commented Jun 1, 2017

Thanks for reporting! Fixing in #16.

abhinav added a commit that referenced this issue Jun 3, 2017
@abhinav
compact: Fix encoding of doubles (#16)
fe9e6b6 
The compact protocol encodes doubles in little endian byte ordering, not
big endian.

Resolves #15
@abhinav
Copy link
Owner

abhinav commented Jun 3, 2017 •
edited

Fix released in 0.3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhinav @jacobstanley