Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH handler/listener plugins #1398

Merged
merged 11 commits into from
Apr 24, 2024
Merged

SSH handler/listener plugins #1398

merged 11 commits into from
Apr 24, 2024

Conversation

abhinavsingh
Copy link
Owner

No description provided.

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Apr 23, 2024
@abhinavsingh
Copy link
Owner Author

@webknjaz Wondering if we need to update flake8 version for proxy.py repository too. Unsure what happened yesterday, but:

  1. I merged couple of PRs yesterday, all good
  2. But since late last night we started getting pre-commit errors on this PR
  3. Locally all pre-commit hooks seem to pass

So I figured may be some upstream dep has changed, though unsure which one

- repo: https://github.com/PyCQA/flake8.git
  rev: 3.9.2
  hooks:
  - id: flake8
    language_version: python3
    additional_dependencies:
    - flake8-2020 >= 1.6.0
    - flake8-docstrings >= 1.5.0
    - flake8-pytest-style >= 1.2.2
    - wemake-python-styleguide >= 0.16.1

I investigated above packages and none seem to have released a new version yesterday.

Unsure if pre-commit image itself has changed sometime yesterday resulting pre-commit failures.

@abhinavsingh
Copy link
Owner Author

abhinavsingh commented Apr 24, 2024

@webknjaz Wondering if we need to update flake8 version for proxy.py repository too. Unsure what happened yesterday, but:

  1. I merged couple of PRs yesterday, all good
  2. But since late last night we started getting pre-commit errors on this PR
  3. Locally all pre-commit hooks seem to pass

So I figured may be some upstream dep has changed, though unsure which one

- repo: https://github.com/PyCQA/flake8.git
  rev: 3.9.2
  hooks:
  - id: flake8
    language_version: python3
    additional_dependencies:
    - flake8-2020 >= 1.6.0
    - flake8-docstrings >= 1.5.0
    - flake8-pytest-style >= 1.2.2
    - wemake-python-styleguide >= 0.16.1

I investigated above packages and none seem to have released a new version yesterday.

Unsure if pre-commit image itself has changed sometime yesterday resulting pre-commit failures.

Screenshot 2024-04-24 at 2 47 51 PM

Another hint I got that something has changed, because pre-commit started sending these suggestions, which frankly looks non-sensical.

@abhinavsingh
Copy link
Owner Author

abhinavsingh commented Apr 24, 2024

Indeed, can verify this by comparing hash of pre-commit image:

  1. Pre-commit run from develop (HEAD) is using an image from 2023 https://results.pre-commit.ci/run/github/12228178/1713880307.Z5PTirFHQc-YfBNGH5yqJA
  2. Since last night, pre-commit started using a newer image, which uses Python 3.12 :(. https://results.pre-commit.ci/run/github/12228178/1713923336.SpNwhUIiRc-9jaXw_TljCg

Hence the unexpected errors IIUC

@abhinavsingh abhinavsingh merged commit 81aa82b into develop Apr 24, 2024
52 checks passed
@abhinavsingh abhinavsingh deleted the listener branch April 24, 2024 09:43
@webknjaz
Copy link
Contributor

@abhinavsingh yes, I'm getting this in other projects too. It looks like the pre-commit.ci service updated their container images and now default to using Python 3.12 there. I'm trying to figure out what updates to make elsewhere but hitting problems with other plugin incompatibilities like wemake-services/wemake-python-styleguide#2933 so I don't have a final solution yet. The workaround of pinning the Python version seems like a reasonable stopgap for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants