Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize manager in main thread for event queue #239

Merged
merged 1 commit into from
Dec 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@

coverage.xml
proxy.py.iml
*.pyc

*.pyc
*.egg-info
*.csr
*.crt
*.key

venv*

cover
htmlcov
dist
build

*.egg-info
proxy/public
2 changes: 1 addition & 1 deletion proxy/common/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
DEFAULT_PLUGINS = ''
DEFAULT_PORT = 8899
DEFAULT_SERVER_RECVBUF_SIZE = DEFAULT_BUFFER_SIZE
DEFAULT_STATIC_SERVER_DIR = PROXY_PY_DIR
DEFAULT_STATIC_SERVER_DIR = os.path.join(PROXY_PY_DIR, "public")
DEFAULT_THREADLESS = False
DEFAULT_TIMEOUT = 10
DEFAULT_VERSION = False
Expand Down
5 changes: 4 additions & 1 deletion proxy/core/acceptor/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ def __init__(self, flags: Flags, work_klass: Type[ThreadlessWork]) -> None:
self.event_dispatcher: Optional[EventDispatcher] = None
self.event_dispatcher_thread: Optional[threading.Thread] = None
self.event_dispatcher_shutdown: Optional[threading.Event] = None
self.manager: Optional[multiprocessing.managers.SyncManager] = None

if self.flags.enable_events:
self.event_queue = EventQueue()
self.manager = multiprocessing.Manager()
self.event_queue = EventQueue(self.manager.Queue())

def listen(self) -> None:
self.socket = socket.socket(self.flags.family, socket.SOCK_STREAM)
Expand Down
6 changes: 2 additions & 4 deletions proxy/core/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ class EventQueue:
7. Publisher ID (optional) - Optionally, publishing entity unique name / ID
"""

def __init__(self) -> None:
super().__init__()
self.manager = multiprocessing.Manager()
self.queue = self.manager.Queue()
def __init__(self, queue: DictQueueType) -> None:
self.queue = queue

def publish(
self,
Expand Down
2 changes: 1 addition & 1 deletion tests/core/test_event_dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TestEventDispatcher(unittest.TestCase):

def setUp(self) -> None:
self.dispatcher_shutdown = threading.Event()
self.event_queue = EventQueue()
self.event_queue = EventQueue(multiprocessing.Manager().Queue())
self.dispatcher = EventDispatcher(
shutdown=self.dispatcher_shutdown,
event_queue=self.event_queue)
Expand Down
8 changes: 5 additions & 3 deletions tests/core/test_event_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@

from proxy.core.event import EventQueue, eventNames

MANAGER = multiprocessing.Manager()


class TestCoreEvent(unittest.TestCase):

@mock.patch('time.time')
def test_publish(self, mock_time: mock.Mock) -> None:
mock_time.return_value = 1234567
evq = EventQueue()
evq = EventQueue(MANAGER.Queue())
evq.publish(
request_id='1234',
event_name=eventNames.WORK_STARTED,
Expand All @@ -41,15 +43,15 @@ def test_publish(self, mock_time: mock.Mock) -> None:
})

def test_subscribe(self) -> None:
evq = EventQueue()
evq = EventQueue(MANAGER.Queue())
q = multiprocessing.Manager().Queue()
evq.subscribe('1234', q)
ev = evq.queue.get()
self.assertEqual(ev['event_name'], eventNames.SUBSCRIBE)
self.assertEqual(ev['event_payload']['sub_id'], '1234')

def test_unsubscribe(self) -> None:
evq = EventQueue()
evq = EventQueue(MANAGER.Queue())
evq.unsubscribe('1234')
ev = evq.queue.get()
self.assertEqual(ev['event_name'], eventNames.UNSUBSCRIBE)
Expand Down
3 changes: 2 additions & 1 deletion tests/core/test_event_subscriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import os
import threading
import unittest
import multiprocessing
from typing import Dict, Any

from unittest import mock
Expand All @@ -26,7 +27,7 @@ class TestEventSubscriber(unittest.TestCase):
def test_event_subscriber(self, mock_time: mock.Mock) -> None:
mock_time.return_value = 1234567
self.dispatcher_shutdown = threading.Event()
self.event_queue = EventQueue()
self.event_queue = EventQueue(multiprocessing.Manager().Queue())
self.dispatcher = EventDispatcher(
shutdown=self.dispatcher_shutdown,
event_queue=self.event_queue)
Expand Down